ci(benchmarks): bump setup-dotnet SDK 8.0.x → 10.0.x (protected-only ahead of #233)#234
Merged
Merged
Conversation
The benchmarks csproj is bumped to <TargetFramework>net10.0</TargetFramework> in the v0.3.4 vNext stack (PR #227, closes #220), but the post-merge Benchmarks workflow installs only 8.0.x SDK — restore fails. Protected-only PR ahead of #233 (vNext -> main, v0.3.4 release). Extracted per protected-file-pr-split so the bigger release PR can merge through the normal ruleset rather than admin-bypass. The matching csproj change ships in #233.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Single-file protected PR extracted from the v0.3.4 vNext stack so the larger release PR (#233) can merge through the standard ruleset rather than admin-bypass (which would waive
required_review_thread_resolutionon the full 18-file diff).Change:
.github/workflows/benchmarks.yamlsetup-dotnetstep:dotnet-version: 8.0.x→10.0.x.Why now: v0.3.4 bumps
benchmarks/Wolfgang.TryPattern.Benchmarks.csprojto<TargetFramework>net10.0</TargetFramework>(PR #227, closes #220). Without the matching SDK install, the post-merge Benchmarks workflow run fails on restore.Expected CI state
Detect .NET Projects❌ — expected, that's the whole point of this PR; touches.github/workflows/*.yamlStage 1 / 2 / 3SKIPPED — gated ondetect-projects.outputs.has-projectsMerge path
Admin-bypass merge after maintainer reviews the one-line diff. Then merge
origin/mainback intovNextand #233 flips to MERGEABLE without bypass.Related
protected-file-pr-splitskill (validated on DateTime-Extensions PR docs(docfx): add custom favicon.svg derived from logo identity #195 ahead of [Maintenance] CI/CD: Build reproducibility verification (deterministic builds across runners) #183)