Skip to content

fix(build-pr): restore -UseBasicParsing on Invoke-WebRequest#230

Merged
Chris-Wolfgang merged 1 commit into
mainfrom
fix/build-pr-usebasicparsing
Jun 30, 2026
Merged

fix(build-pr): restore -UseBasicParsing on Invoke-WebRequest#230
Chris-Wolfgang merged 1 commit into
mainfrom
fix/build-pr-usebasicparsing

Conversation

@Chris-Wolfgang

Copy link
Copy Markdown
Owner

Summary

Adds -UseBasicParsing to the Invoke-WebRequest call in the gitleaks auto-installer of scripts/build-pr.ps1.

On Windows PowerShell 5.1, Invoke-WebRequest without -UseBasicParsing uses the legacy IE-based parser and throws "the Internet Explorer engine is not available..." on stock / minimal Windows. The Windows branch is reachable from PS 5.1 (entered via the $env:OS -match 'Windows' half of the guard). PowerShell 7+ accepts the switch as a no-op, so this works on both hosts at zero cost.

Canonical fix from Chris-Wolfgang/repo-template#418, fanned out to the fleet. build-pr.ps1 is not a protected file, so this merges through the normal ruleset.

🤖 Generated with Claude Code

@Chris-Wolfgang Chris-Wolfgang merged commit f04b506 into main Jun 30, 2026
8 checks passed
@Chris-Wolfgang Chris-Wolfgang deleted the fix/build-pr-usebasicparsing branch June 30, 2026 00:42
Chris-Wolfgang added a commit that referenced this pull request Jun 30, 2026
Tier-2 cleanup round surfaced by the v0.3.3 AI code-review pass. No
public API change in Wolfgang.TryPattern itself; PATCH bump per SemVer.

Contents this release:

- Docs: README database example converted to Try.RunAsync /
  ExecuteReaderAsync (#226, closes #221)
- Perf: benchmarks project bumped net8.0 -> net10.0 + workflow SDK
  install bumped to 10.0.x (#227, closes #220)
- Fix: PublicApiAnalyzer manifest — Result<T>.Value.get moved into
  per-TFM split (modern: T?, legacy: T); the previous top-level entry
  was silently wrong against modern builds (#228, closes #219)
- Chore: xunit.runner.visualstudio bumped 3.0.0 -> 3.1.5 (latest 3.x
  GA; xunit core 2.9.3 stays put — 3.x runner supports xunit 1/2/3)
  (#229, closes #218)
- Chore: test directory + namespace aligned under single
  Wolfgang.TryPattern.Tests.Unit identity (directory, csproj,
  assembly, namespace, sln + stryker config) (#231, closes #222)
- Fix: scripts/build-pr.ps1 restored -UseBasicParsing on
  Invoke-WebRequest (#230, merged directly to main)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant