chore(tests): bump xunit.runner.visualstudio 3.0.0 → 3.1.5 (#218)#229
Merged
Conversation
4 tasks
Moves the net8/9/10 ItemGroup runner from 3.0.0 to 3.1.5 (latest GA on the 3.x line). The xunit core packages stay at 2.9.3 — runner 3.x explicitly supports xunit 1.x / 2.x / 3.x test discovery, so the mismatched-major shape is a non-issue on real GA releases. Earlier round of this PR mistakenly tried to downgrade to 2.8.2 on the basis of a CLAUDE.md note saying "3.x is incompatible with xunit v2." The note dates from the 3.0.0-pre.* era, when v2 discovery actually was broken; the GA 3.x line restored it. 2.8.2 is the *ceiling* of the 2.x line (no newer 2.x exists), so the alleged fix was actually sacrificing ~14 months of runner maintenance. Upgrading instead. Verified locally: 88/88 tests pass on net8.0, net9.0, and net10.0 with runner 3.1.5 + xunit 2.9.3. Follow-up: CLAUDE.md's xunit runner rule needs to be updated to reflect that 3.x GA is compatible (separate change, not in this PR). Closes #218
Chris-Wolfgang
force-pushed
the
tier2/218-xunit-runner-align
branch
from
9e95165 to
2b3180b
Compare
Chris-Wolfgang
changed the title
Chris-Wolfgang
added a commit
that referenced
this pull request
Jun 30, 2026
Tier-2 cleanup round surfaced by the v0.3.3 AI code-review pass. No public API change in Wolfgang.TryPattern itself; PATCH bump per SemVer. Contents this release: - Docs: README database example converted to Try.RunAsync / ExecuteReaderAsync (#226, closes #221) - Perf: benchmarks project bumped net8.0 -> net10.0 + workflow SDK install bumped to 10.0.x (#227, closes #220) - Fix: PublicApiAnalyzer manifest — Result<T>.Value.get moved into per-TFM split (modern: T?, legacy: T); the previous top-level entry was silently wrong against modern builds (#228, closes #219) - Chore: xunit.runner.visualstudio bumped 3.0.0 -> 3.1.5 (latest 3.x GA; xunit core 2.9.3 stays put — 3.x runner supports xunit 1/2/3) (#229, closes #218) - Chore: test directory + namespace aligned under single Wolfgang.TryPattern.Tests.Unit identity (directory, csproj, assembly, namespace, sln + stryker config) (#231, closes #222) - Fix: scripts/build-pr.ps1 restored -UseBasicParsing on Invoke-WebRequest (#230, merged directly to main)
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps the net8/9/10 ItemGroup runner from
xunit.runner.visualstudio 3.0.0to3.1.5(latest GA on the 3.x line). The xunit core packages stay at2.9.3— runner 3.x explicitly supports xunit 1.x / 2.x / 3.x test discovery, so the mismatched-major shape is a non-issue on real GA releases.Reversed from the original direction. The first version of this PR tried to downgrade to
2.8.2on the basis of CLAUDE.md's note saying "3.x is incompatible with xunit v2." That note dates from the3.0.0-pre.*era when v2 discovery actually was broken; GA 3.x restored it.2.8.2is the ceiling of the 2.x line (no newer 2.x exists), so the downgrade would have sacrificed ~14 months of runner maintenance. Upgrading to the latest 3.x line instead.Stacked on #228.
Test plan
Local verification — 88/88 tests pass on each modern TFM with runner
3.1.5+ xunit core2.9.3:Follow-up
The shared CLAUDE.md at
C:\Source\GitHub\CLAUDE.mdstill has the stale "xunit.runner.visualstudio 2.8.2 (NOT 3.x)" rule. Should be updated separately to reflect that GA 3.x is compatible. Not in this PR's scope.Closes #218