fix: remove the visual model judgment method that checks if the model…

[skymkmk]

Remove the visual model judgment method that checks if the model name contains 'preview' from the OpenAI API to prevent models like o1-preview from being classified as visual models

💻 变更类型 | Change Type

• feat
• fix
• refactor
• perf
• style
• test
• docs
• ci
• chore
• build

🔀 变更说明 | Description of Change

通过 preview 来判断是否为视觉模型是过时的做法，最新的 o1-preview 暂时并不支持视觉，但在发送请求时会默认带上 4000 token 的限制，所以从 OpenAI 的 client 中去除该判断。

Summary by CodeRabbit

• New Features

  • Enhanced API functionality for vision models by simplifying the conditions for applying the max_tokens property, improving the handling of requests.

• Bug Fixes

  • Resolved an issue where max_tokens was not consistently applied to vision model requests.

[vercel]

@skymkmk is attempting to deploy a commit to the NextChat Team on Vercel.

A member of the Team first needs to authorize it.

[coderabbitai]

Walkthrough

The changes involve a modification to the ChatGPTApi class in the openai.ts file, specifically adjusting the logic for including the max_tokens property in the requestPayload for vision models. The previous condition required both a visionModel and the presence of "preview" in the modelConfig.model. The new logic simplifies this by only requiring the presence of a visionModel, allowing max_tokens to be set to either modelConfig.max_tokens or 4000.

Changes

File	Change Summary
app/client/platforms/openai.ts	Modified the logic in the ChatGPTApi class to simplify the condition for setting max_tokens for vision models.

Poem

In the land of code where changes bloom,
A rabbit hops, dispelling gloom.
With max_tokens now set free,
Vision models dance with glee!
Hooray for logic, clear and bright,
Let’s celebrate this coding delight! 🐇✨

Tip

OpenAI O1 model for chat

• We have deployed OpenAI's latest O1 model for chat.
• OpenAI claims that this model has superior reasoning capabilities than their GPT-4o model.
• Please share any feedback with us in the discussions post.

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 07c6fe5 and 6bb01bc.

Files selected for processing (1)

• app/client/platforms/openai.ts (1 hunks)

Additional comments not posted (1)

app/client/platforms/openai.ts (1)

200-202: LGTM!

The removal of the "preview" check simplifies the logic and ensures that the max_tokens property is correctly added to the requestPayload for all vision models, regardless of their naming. This change aligns with the PR objective and fixes the issue of misclassifying non-visual models as visual models based on an outdated naming convention.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

Your build has completed!

Preview deployment