Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: summarize model customization #5426

Merged
merged 2 commits into from
Sep 14, 2024

Conversation

skymkmk
Copy link
Contributor

@skymkmk skymkmk commented Sep 13, 2024

💻 变更类型 | Change Type

  • feat
  • fix
  • refactor
  • perf
  • style
  • test
  • docs
  • ci
  • chore
  • build

🔀 变更说明 | Description of Change

现在用户可以自定义模型进行标题生成与回忆总结,并且可以手动进行标题生成

📝 补充信息 | Additional Information

complete #5417

由于我的 API 提供商提供的 API 都是基于 OpenAI 结构的,我无法测试诸如 gemini、Claude 等其他 API 提供商结构,理论上来说逻辑应该是通顺的。

标题刷新按钮在手机上的布局可能不好看(不对称),但我一时间也想不到更好的布局方案。

现在手动刷新标题发送的历史长度基于用户在模型设置里设置的发送历史的长度,最短为最近的一条历史消息。

Summary by CodeRabbit

Release Notes

  • New Features

    • Added a reload button to refresh chat sessions, enhancing user interaction.
    • Introduced a compression model selection feature in the ModelConfigList component.
  • Localization Enhancements

    • Added new translations for refresh functionality and compression model across multiple languages, improving accessibility for non-English speakers.
  • Bug Fixes

    • Improved the summarization process in chat sessions for better performance and clarity.

These updates enhance user experience by providing new functionalities and improved localization support.

Copy link

vercel bot commented Sep 13, 2024

@skymkmk is attempting to deploy a commit to the NextChat Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

coderabbitai bot commented Sep 13, 2024

Walkthrough

The changes introduce new functionalities to the chat and model configuration components, including a reload button for refreshing chat sessions and the ability to select a compression model. Additionally, localization strings for multiple languages have been added to support these new features, enhancing user experience. The summarization logic in the chat store has been streamlined, and configuration settings for the model have been updated to include a new compression model.

Changes

Files Change Summary
app/components/chat.tsx Added a reload button with a toast notification for refreshing chat sessions.
app/components/model-config.tsx Introduced a dropdown for selecting a compression model, updating the model configuration accordingly.
app/locales/*.ts Added localization strings for new features (refresh functionality and compression model) in multiple languages: Arabic, Bengali, Chinese, Czech, German, English, Spanish, French, Indonesian, Italian, Japanese, Korean, Norwegian, Portuguese, Russian, Slovak, Turkish, Taiwanese, and Vietnamese.
app/store/chat.ts Modified the summarizeSession method to accept a new parameter and removed the getSummarizeModel function, streamlining the summarization process.
app/store/config.ts Updated default model configuration to use "gpt-4o-mini" and added properties for compression model and provider name.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant ChatComponent
    participant ChatStore

    User->>ChatComponent: Click Reload Button
    ChatComponent->>ChatStore: summarizeSession(true)
    ChatStore->>ChatComponent: Show Toast Notification
Loading

🐰 In the meadow where rabbits play,
A reload button brightens the day!
With models to compress and toast to cheer,
Our chat's now smoother, let’s all draw near!
Hopping with joy, we celebrate,
These changes make our chat first-rate! 🌼✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

Your build has completed!

Preview deployment

@skymkmk
Copy link
Contributor Author

skymkmk commented Sep 13, 2024

才发现 #5369 好像已经做了

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically.


I just discovered that #5369 seems to have been done

@Dogtiti
Copy link
Member

Dogtiti commented Sep 13, 2024

#5369 的问题在于只通过model name无法判断要用哪个api client
然后你这边的pr我的建议是分开,一个pr尽量一个功能,例如这个刷新的功能可能有待商榷
@lloydzhou 一起看看这里~

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically.


The problem with #5369 is that it is impossible to determine which api client to use only through the model name.
Then my suggestion for your PR is to separate it. Each PR should have one function. For example, the refresh function may be discussed.
@lloydzhou Let’s take a look here~

@Dogtiti Dogtiti mentioned this pull request Sep 13, 2024
10 tasks
app/store/config.ts Show resolved Hide resolved
app/store/chat.ts Show resolved Hide resolved
@Dogtiti Dogtiti merged commit b32d82e into ChatGPTNextWeb:main Sep 14, 2024
1 of 2 checks passed
lloydzhou added a commit to ConnectAI-E/ChatGPT-Next-Web that referenced this pull request Oct 9, 2024
lloydzhou added a commit that referenced this pull request Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants