Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add o1 model #5416

Merged
merged 3 commits into from
Sep 13, 2024
Merged

feat: add o1 model #5416

merged 3 commits into from
Sep 13, 2024

Conversation

skymkmk
Copy link
Contributor

@skymkmk skymkmk commented Sep 13, 2024

💻 变更类型 | Change Type

  • feat
  • fix
  • refactor
  • perf
  • style
  • test
  • docs
  • ci
  • chore
  • build

🔀 变更说明 | Description of Change

添加了 o1-mini 与 o1-preview 模型

📝 补充信息 | Additional Information

o1 系列模型暂时不支持多模态,system 角色,流式传输,工具函数(plugin 插件),温度,核采样,两个惩罚度等,OpenAI 可能会在下面几周添加这些功能的支持。

Summary by CodeRabbit

  • New Features

    • Introduced support for new models "o1-mini" and "o1-preview" with updated knowledge cut-off dates.
    • Enhanced message processing logic for the "o1" model, including exclusion of system messages and fixed parameters for improved performance.
    • Adjusted request timeout settings to optimize processing time for the "o1" model.
  • Bug Fixes

    • Improved handling of model-specific configurations to ensure accurate message processing.

Copy link

vercel bot commented Sep 13, 2024

@skymkmk is attempting to deploy a commit to the NextChat Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

coderabbitai bot commented Sep 13, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The changes introduce logic in the ChatGPTApi class to handle a new model prefix "o1," affecting message processing and request parameters. System messages are excluded for "o1" models, and certain parameters are fixed. Additionally, two new models, "o1-mini" and "o1-preview," are added to the KnowledgeCutOffDate record with a cut-off date of "2023-10," and they are included in the openaiModels array for model tracking.

Changes

Files Change Summary
app/client/platforms/openai.ts Added logic in ChatGPTApi to handle "o1" model prefix, modifying message processing and request parameters.
app/constant.ts Added "o1-mini" and "o1-preview" to KnowledgeCutOffDate and included them in the openaiModels array.

Possibly related PRs

  • feat: add o1 model #5416: The changes in this PR directly relate to the handling of the "o1" model prefix in the ChatGPTApi class, which is also the focus of the main PR. Both PRs introduce logic to manage the "o1" model and its parameters, indicating a strong connection at the code level.

Poem

In a meadow where ideas bloom,
A rabbit hops, dispelling gloom.
New models join the playful dance,
With "o1" leading, they take a chance.
Knowledge grows, like carrots bright,
In code we trust, our future's light! 🐇✨

Tip

OpenAI O1 model for chat
  • We have deployed OpenAI's latest O1 model for chat.
  • OpenAI claims that this model has superior reasoning capabilities than their GPT-4o model.
  • Please share any feedback with us in the discussions post.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

Your build has completed!

Preview deployment

@skymkmk
Copy link
Contributor Author

skymkmk commented Sep 13, 2024

Is the default timeout a bit too short? When using the o1 model, my average time is generally over 60 seconds, with an average of around 90 seconds. Should the timeout threshold be increased for o1?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants