Conversation
* Fixed Operations route to not have subId * Remving subid from the path due to prev commit
* Add missing enum for aggregation type * Update enum order
* Extract readme.nodejs.md from databox/resource-manager/readme.md * Revert changes about azure-sdk-for-ruby and azure-sdk-for-java
* Added missing 202 Accepted response code to Api Management * Updated example for Api Management Service using response code 202 * Updated example for Api Management Service MSI using response code 202 * Updated example for Api Management Service with Custom Hostname using response code 202
* Fix Swagger Linting Error for Microsoft.Features * Remove additional properties in examples
…ion to cancel API (#3917) * Add SecureInput Property to Activity Add IsRecursive Option to Cancel API * Fix Formating Issues * Fix formats
…ces swagger (#3889) * update machine learning compute portion of the machine learning services swagger * add systemUpdateCompute example * update examples * added long-running op update accordingly * remote wrong readOnly
* Add azure-sdk-for-js to compute/resource-manager/readme.md * Fix api-version of disk.json folder in compute/resource-manager/readme.md * Revert disk api-version folder change
* More detail added to the descriptions. Changes made to description strings. * Addressed review comments Addressed review comments on the updateable fields. * Added another updateable property description Added another updateable property description
* Add degreeOfParallelismPercent to JobInformationBasic * Add degreeOfParallelismPercent to JobInformationBasic * add hierarchyQueueNode to JobInformation(Basic) * Tiny change to test github merge
#3895) * Kusto: Added more features such as: database operations, check cluster/database name availability, cluster - start/stop, event hub data connection, list skus, list resource skus * added missed refrence + minor fixes * fixed enum definition * renamed example * Added renamed example * Fixed tracked resource validation errors * fixed model validation errors * Fixed missing comma * model validation error fix * Revert "model validation error fix" This reverts commit c04ad73. * fixed exmaple * PR changes * Moved files to "preview" folder * fixed broken refrences * readme file syntax fixes * fixed ListSkusByResource operation id * renamed query uri to uri and removed tags definition from databases (as it is not supported) * change "capacity" value in examples from null to 2
* Add MoT to Private Specs Repository * PR Comments * PR Comments II * Minor spacing fix * Update momentOfTruthPostProcessing.js
…3963) * Copy of previous version of API 2018-05-31 * Applying changes for new version of CostManagement APIs 2018-08-31 * Fixing spec errors using validation tools
…use predefined constants (#3971)
@dashult discovered the discrepancy between the tags `package-2018-06` and `package-2018-06-exclude-gallery`. The difference is causing the modeler to choke on duplicate type definitions for the TypeScript and Node.js generators.
* Front Door public preview Front Door public preview * Add suppression for operationsAPIImplementation as we use NRP's operations/ API Add suppression for operationsAPIImplementation as we use NRP's operations/ API * Fix typo Fix typo * Fix indentation Fix indentation * Fix resourceState in definition WebApplicationFirewallPolicy Swagger did not contain the return value ResourceState. * Fix resourceState case * Delete vim.exe.stackdump
#3974) * Removing reportconfig paths from stable version, as they are in preview version and in new version these are to be removed * Incorporating review comments
* Azure Deployment Manager: Swagger + examples for Preview * DeploymentManager: updates to examples, swagger * DeploymentManager: update readme * Reorder DeploymentMode, fix extra token in samples json * Remove obsolete example files * Incorporated feedback * Semantic validation * Fix validation failures. Adjust contracts * Adjust contracts; add examples * Add SDK generation settings for all sdks * Add docs link * Incorporated feedback + updated descriptions
* Moving to Public Repository Moving to Public Repository * moving inside preview folder * updating relative path
…l OS Disks (#3944) * Added diffDiskSettings property as part of Swagger changes needed for Ephemeral VM\VMSS * updated comment * updated swagger specs for diffdisksettings property * updated swagger spec comments for diff disk settings [property * added example to create Diff OS disk scaleset * updated 2018-10-01 version specs with diffdisk property
* Rename Post to Grants * Update graphrbac.json
* Update deploymentmanager/resource-manager/readme.nodejs.md * Revert generate-metadata change
…g DiffDiskSettings Property (#3995) * Added diffDiskSettings property as part of Swagger changes needed for Ephemeral VM\VMSS * updated comment * updated swagger specs for diffdisksettings property * updated swagger spec comments for diff disk settings [property * added example to create Diff OS disk scaleset * updated 2018-10-01 version specs with diffdisk property * added example file for creating VM with diffdisksettings property
sashanm
pushed a commit
that referenced
this pull request
Apr 26, 2021
* Changes for supporting User Assigned Identity and CMK in Resource CRUD (#1) * Supporting User Assigned Identity and CMK. * Indentation fixes * Added Examples for CRUD with CMK * Added more fields to the Operation Resource * Fixing Examples * Fix for the Prettier check validation * Added new Api-version for the changes * Fixed the api-version in json files * Marked operation result as long running.
sashanm
pushed a commit
that referenced
this pull request
Apr 26, 2021
…review/2019-11-04-preview (Azure#11266) * New Readme Config File * New Go Language Readme Config File * New Typescript Language Readme Config File * New Python Language Readme Config File * New C# Language Readme Config File * New Ruby Language Readme Config File * New Swagger Spec File * New Swagger Example Spec File * New Swagger for Azure Quantum RP * Adding MSI fields * Incorporating ARM feedback (#1) * Picking up changes from RPSaaS. * -ruby * go * clean up readme config * -java * preview path * python version * incorporate feedback * read-only * ids * prettier * removing patch * addressing feedback * prettier fix * removing tags - coming from TrackedResource * un-referencing trackedresource * adding patch, referring to the common-type tracked resource * prettier fix * Adds suppression to readme * Adds suppression to readme Co-authored-by: Adele Bai <adbai@microsoft.com> Co-authored-by: Mahmut Burak Senol <masenol@microsoft.com> Co-authored-by: masenol <54191670+masenol@users.noreply.github.com>
sashanm
pushed a commit
that referenced
this pull request
Apr 26, 2021
* Microsoft.DataProtection swagger changes * Added example file FindRestorableTimeRanges.json * Adding 202 GetOperationResult (#1) * adding 202 GetOperationResult * added headers Co-authored-by: Mayank Aggarwal <mayaggar@microsoft.com> * pr comments fixes * prettier fixes * adding fix for x-ms-error-response * Added missed DppWorkerRequest object in swagger json * Validation fixes * changes for request * removing objectType Co-authored-by: Mayank Aggarwal <mayankagg9722@gmail.com> Co-authored-by: Mayank Aggarwal <mayaggar@microsoft.com>
sashanm
added a commit
that referenced
this pull request
Apr 26, 2021
* new api changes * referer url change
sashanm
pushed a commit
that referenced
this pull request
Apr 26, 2021
* Add webpubsub swagger Add custom words Update webpubsub.json Update webpubsub.json Resolve comments Update webpubsub.json resolve comments Update operationId for existence check [wps] update python generation section and client name for all languages (#1) * add python stuff * make title across languages the same * Update version * Update some constraints * Update webpubsub.json * rename to GetServiceStatus * Update readme.md * Update readme.md * Update readme.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-versionin the path should match theapi-versionin the spec).Quality of Swagger