Skip to content

Adding an example file for creating VM with differencing os disk using DiffDiskSettings Property#3995

Merged
jhendrixMSFT merged 9 commits intoAzure:masterfrom
hari-bodicherla:master
Sep 24, 2018
Merged

Adding an example file for creating VM with differencing os disk using DiffDiskSettings Property#3995
jhendrixMSFT merged 9 commits intoAzure:masterfrom
hari-bodicherla:master

Conversation

@hari-bodicherla
Copy link
Contributor

@hari-bodicherla hari-bodicherla commented Sep 24, 2018

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI
Copy link

AutorestCI commented Sep 24, 2018

Automation for azure-sdk-for-js

Nothing to generate for azure-sdk-for-js

@AutorestCI
Copy link

AutorestCI commented Sep 24, 2018

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

@hari-bodicherla
Copy link
Contributor Author

@jhendrixMSFT , could you please review these changes. These are additional simple changes on the top of main PR : #3944 . thanks

@AutorestCI
Copy link

AutorestCI commented Sep 24, 2018

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI
Copy link

AutorestCI commented Sep 24, 2018

Automation for azure-sdk-for-node

Nothing to generate for azure-sdk-for-node

@AutorestCI
Copy link

AutorestCI commented Sep 24, 2018

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Sep 24, 2018

Automation for azure-sdk-for-go

Encountered a Subprocess error: (azure-sdk-for-go)

Command: dep ensure
Finished with return code 1
and output:

The following issues were found in Gopkg.toml:

  ✗ unable to deduce repository and source type for "golang.org/x/crypto": unable to read metadata: go-import metadata not found

ProjectRoot name validation failed

@jhendrixMSFT jhendrixMSFT merged commit 04d9e24 into Azure:master Sep 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments