Add MoT to Private Specs Repository#3950
Conversation
Automation for azure-sdk-for-rubyUnable to detect any generation context from this PR. |
Automation for azure-sdk-for-pythonUnable to detect any generation context from this PR. |
Automation for azure-sdk-for-nodeUnable to detect any generation context from this PR. |
Automation for azure-sdk-for-javaUnable to detect any generation context from this PR. |
Automation for azure-sdk-for-jsUnable to detect any generation context from this PR. |
Automation for azure-sdk-for-goUnable to detect any generation context from this PR. |
|
Can one of the admins verify this patch? |
|
@sarangan12 You don't need to add custom formatting for this, you can just post the contents of |
| } | ||
|
|
||
| function compareJsonRef(beforeJsonRef, afterJsonRef) { | ||
| return (beforeJsonRef.replace(/json:\d+:\d+/, '') == afterJsonRef.replace(/json:\d+:\d+/, '')); |
There was a problem hiding this comment.
What's the intent behind this change?
There was a problem hiding this comment.
This is related to the issue specified by Joel.
| } | ||
|
|
||
| module.exports = { | ||
| postGithubComment: function(owner, repository, prNumber, commentBody) { |
There was a problem hiding this comment.
Are we concerned that every time a commit is pushed, a new build will run and this will create a new comment? If so, maybe we can put an identifier in the comment and then either create a new comment or update the existing one if found. SwaggerToSdk is already doing this (it matches on the header text) but you should also be able to do it by inserting an HTML comment like <!-- momentoftruth --> which will be invisible to the user but will make it easy to locate the comment to update.
5 participants
@salameer @veronicagg FYI......