Skip to content

Remove serverAppSecret which is not required for AKS cluster updates #3949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sergey-shandar merged 1 commit into from
Sep 19, 2018
Merged

Remove serverAppSecret which is not required for AKS cluster updates #3949

sergey-shandar merged 1 commit into from
Sep 19, 2018
+1 −2

Conversation

@feiskyer
Copy link
Member

@feiskyer feiskyer commented Sep 19, 2018

Remove serverAppSecret which is not required for AKS cluster updates.

Without this, scale up AKS cluster would report error:

containerservice.ManagedClustersClient#CreateOrUpdate: Invalid input: autorest/validation: validation failed: parameter=parameters.ManagedClusterProperties.AadProfile.ServerAppSecret constraint=Null value=(*string)(nil) details: value can not be null; required parameter

Note: Go SDK should be also be updated after this.

cc @weinong @mboersma

@AutorestCI
Copy link

AutorestCI commented Sep 19, 2018 •
edited
Loading

Automation for azure-sdk-for-js

Nothing to generate for azure-sdk-for-js

@AutorestCI AutorestCI mentioned this pull request Sep 19, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Sep 19, 2018 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3378

@AutorestCI
Copy link

AutorestCI commented Sep 19, 2018 •
edited
Loading

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#3642

@AutorestCI AutorestCI mentioned this pull request Sep 19, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Sep 19, 2018 •
edited
Loading

Automation for azure-sdk-for-ruby

A PR has been created for you:
Azure/azure-sdk-for-ruby#1664

@AutorestCI
Copy link

AutorestCI commented Sep 19, 2018 •
edited
Loading

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@azuresdkci
Copy link
Contributor

azuresdkci commented Sep 19, 2018

Can one of the admins verify this patch?

@AutorestCI AutorestCI mentioned this pull request Sep 19, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Sep 19, 2018 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#2755

@sergey-shandar
Copy link
Contributor

sergey-shandar commented Sep 19, 2018

@feiskyer, @mboersma, @weinong this's breaking changes. What's the reason to make breaking changes in the stable API?

@sergey-shandar sergey-shandar added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required potential-sdk-breaking-change labels Sep 19, 2018
@sergey-shandar
Copy link
Contributor

sergey-shandar commented Sep 19, 2018 •
edited
Loading

@feiskyer @mboersma @weinong please, ignore my previous question.

@sergey-shandar sergey-shandar merged commit 8571617 into Azure:master Sep 19, 2018
@AutorestCI AutorestCI mentioned this pull request Sep 19, 2018
Merged
@feiskyer feiskyer deleted the remove-serverAppSecret branch September 20, 2018 02:33
@feiskyer
Copy link
Member Author

feiskyer commented Sep 20, 2018

@sergey-shandar Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mboersma mboersma mboersma approved these changes

+2 more reviewers

@sergey-shandar sergey-shandar sergey-shandar approved these changes

@weinong weinong weinong approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@sergey-shandar sergey-shandar

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@feiskyer @AutorestCI @azuresdkci @sergey-shandar @mboersma @weinong