[ACR] Update to 2017-06-01-preview version #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add webhooks and replications as nested resources under registries.
Author
|
@DavidObando Rebased from master branch with managed registry, webhooks, and replications. |
Author
|
Please ignore all the SDK files, they will be removed before sending a PR to Azure repo. |
sajayantony
reviewed
Apr 28, 2017
| :param str registry_name: The name of container registry | ||
| ''' | ||
| if resource_group_name is None: | ||
| resource_group_name = get_resource_group_name_by_registry_name(registry_name) |
There was a problem hiding this comment.
Can you "functionize" - resource_group_name = get_resource_group_name(registry, resource_group_name) and do the If check only in that function?
sajayantony
reviewed
Apr 28, 2017
| namespace.registry_name, namespace.resource_group_name) | ||
| if namespace.location == "".join(registry_location.split()).lower(): | ||
| raise CLIError( | ||
| "Replication should not be in the same location '{}' as the registry." |
There was a problem hiding this comment.
"Replication should not be in the same location '{}' as the registry." [](start = 16, length = 70)
When adding another region don't we make sure that the current region is also there in the replication list?
Author
There was a problem hiding this comment.
I might end up removing this validation. The difference is whether we want to fail the request quickly on the client side or send the request to RP and then fail.
djyou
added a commit
that referenced
this pull request
May 2, 2017
* [ACR] Update to 2017-06-01-preview version Add webhooks and replications as nested resources under registries.
djyou
added a commit
that referenced
this pull request
May 17, 2017
* [ACR] Update to 2017-06-01-preview version Add webhooks and replications as nested resources under registries.
djyou
added a commit
that referenced
this pull request
May 22, 2017
* [ACR] Update to 2017-06-01-preview version Add webhooks and replications as nested resources under registries.
djyou
added a commit
that referenced
this pull request
May 30, 2017
* [ACR] Update to 2017-06-01-preview version Add webhooks and replications as nested resources under registries.
djyou
added a commit
that referenced
this pull request
Jun 5, 2017
* [ACR] Update to 2017-06-01-preview version Add webhooks and replications as nested resources under registries.
djyou
added a commit
that referenced
this pull request
Jun 5, 2017
* [ACR] Update to 2017-06-01-preview version Add webhooks and replications as nested resources under registries.
djyou
added a commit
that referenced
this pull request
Jun 9, 2017
* [ACR] Update to 2017-06-01-preview version Add webhooks and replications as nested resources under registries.
djyou
added a commit
that referenced
this pull request
Jun 12, 2017
* [ACR] Update to 2017-06-01-preview version Add webhooks and replications as nested resources under registries.
djyou
added a commit
that referenced
this pull request
Jun 15, 2017
* [ACR] Update to 2017-06-01-preview version Add webhooks and replications as nested resources under registries.
djyou
pushed a commit
that referenced
this pull request
Jul 26, 2019
* NFSAAS-2316 update to R4 RP standard (#30) * NFSAAS-2316 update to R4 RP standard (#31) * NFSAAS-2316 update to R4 RP standard * NFSAAS-2316 update to R4 RP standard * NFSAAS 2316 R4 update path correction (#32) * NFSAAS-2316 update to R4 RP standard * NFSAAS-2316 update to R4 RP standard * NFSAAS-2316 correction to path in R4 update * NFSAAS-2316 R4 update and structure change (#33) * NFSAAS-2316 update to R4 RP standard * NFSAAS-2316 update to R4 RP standard * NFSAAS-2316 correction to path in R4 update * NFSAAS-2316 R4 update and structure change * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * NFSAAS 2316 R4 update remove wheel (#34) * NFSAAS-2316 update to R4 RP standard * NFSAAS-2316 update to R4 RP standard * NFSAAS-2316 correction to path in R4 update * NFSAAS-2316 R4 update and structure change * NFSAAS-2316 update to R4 remove wheel * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * NFSAAS-2316 R4 update packaging fixes (#35) * NFSAAS 2316 R4 update review comments (#36) * NFSAAS-2316 R4 update packaging fixes * NFSAAS-2316 update R4 review comments Use enum for service level * NFSAAS 2316 R4 corrections to booleans (#37) * NFSAAS-2316 R4 update packaging fixes * NFSAAS-2316 update R4 review comments Use enum for service level * NFSAAS-2316 correction to boolean usage * NFSAAS-2316 update history (#38) * NFSAAS-2316 R4 update packaging fixes * NFSAAS-2316 update R4 review comments Use enum for service level * NFSAAS-2316 correction to boolean usage * NFSAAS-2316 update history * NFSAAS-2316 R4 fixes (#39) * NFSAAS-2316 R4 update packaging fixes * NFSAAS-2316 update R4 review comments Use enum for service level * NFSAAS-2316 correction to boolean usage * NFSAAS-2316 update history * NFSAAS-2316 further fixes to R4 commands * NFSAAS-2316 R4 Fixes (#40) * NFSAAS-2316 R4 update packaging fixes * NFSAAS-2316 update R4 review comments Use enum for service level * NFSAAS-2316 correction to boolean usage * NFSAAS-2316 update history * NFSAAS-2316 further fixes to R4 commands * NFSAAS-2316 R4 fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add webhooks and replications as nested resources under registries.
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Command Guidelines
(see Authoring Command Modules)