[ACR] Improve acr login strategy with fallbacks #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
/cc @djyou @sajayantony Let me know if this looks okay. |
DavidObando
force-pushed
the
daobando/loginfallback
branch
from
8f34fd2 to
34d5629
Compare
djyou
reviewed
Apr 26, 2017
| try: | ||
| cred = acr_credential_show(registry_name) | ||
| username = cred.username | ||
| password = cred.password |
There was a problem hiding this comment.
FYI, this will work for this version. The structure has changed. Please update once you rebase.
|
LGTM. |
djyou
pushed a commit
that referenced
this pull request
Apr 28, 2017
djyou
pushed a commit
that referenced
this pull request
May 2, 2017
djyou
pushed a commit
that referenced
this pull request
May 17, 2017
djyou
pushed a commit
that referenced
this pull request
May 22, 2017
djyou
pushed a commit
that referenced
this pull request
May 30, 2017
djyou
pushed a commit
that referenced
this pull request
Jun 5, 2017
djyou
pushed a commit
that referenced
this pull request
Jun 5, 2017
djyou
pushed a commit
that referenced
this pull request
Jun 9, 2017
djyou
pushed a commit
that referenced
this pull request
Jun 12, 2017
djyou
pushed a commit
that referenced
this pull request
Jun 15, 2017
djyou
pushed a commit
that referenced
this pull request
Jun 19, 2017
djyou
added a commit
that referenced
this pull request
Jun 20, 2017
…te (Azure#3747) * Initial acr login command * expose refresh token retrieving mechanism in profile * added unit tests for refresh token operations * [ACR] Improvement to acr login with AAD Repository querying operations can use AAD now (#36) Renaming tokenserver user_type to credential_type (#37) Rename credential_type to grant_type (#38) Improve acr login strategy with fallbacks (#39) * Add managed registries, webhooks, AAD, and repository delete
djyou
pushed a commit
that referenced
this pull request
Jul 26, 2019
* NFSAAS-2316 update to R4 RP standard (#30) * NFSAAS-2316 update to R4 RP standard (#31) * NFSAAS-2316 update to R4 RP standard * NFSAAS-2316 update to R4 RP standard * NFSAAS 2316 R4 update path correction (#32) * NFSAAS-2316 update to R4 RP standard * NFSAAS-2316 update to R4 RP standard * NFSAAS-2316 correction to path in R4 update * NFSAAS-2316 R4 update and structure change (#33) * NFSAAS-2316 update to R4 RP standard * NFSAAS-2316 update to R4 RP standard * NFSAAS-2316 correction to path in R4 update * NFSAAS-2316 R4 update and structure change * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * NFSAAS 2316 R4 update remove wheel (#34) * NFSAAS-2316 update to R4 RP standard * NFSAAS-2316 update to R4 RP standard * NFSAAS-2316 correction to path in R4 update * NFSAAS-2316 R4 update and structure change * NFSAAS-2316 update to R4 remove wheel * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * NFSAAS-2316 R4 update packaging fixes (#35) * NFSAAS 2316 R4 update review comments (#36) * NFSAAS-2316 R4 update packaging fixes * NFSAAS-2316 update R4 review comments Use enum for service level * NFSAAS 2316 R4 corrections to booleans (#37) * NFSAAS-2316 R4 update packaging fixes * NFSAAS-2316 update R4 review comments Use enum for service level * NFSAAS-2316 correction to boolean usage * NFSAAS-2316 update history (#38) * NFSAAS-2316 R4 update packaging fixes * NFSAAS-2316 update R4 review comments Use enum for service level * NFSAAS-2316 correction to boolean usage * NFSAAS-2316 update history * NFSAAS-2316 R4 fixes (#39) * NFSAAS-2316 R4 update packaging fixes * NFSAAS-2316 update R4 review comments Use enum for service level * NFSAAS-2316 correction to boolean usage * NFSAAS-2316 update history * NFSAAS-2316 further fixes to R4 commands * NFSAAS-2316 R4 Fixes (#40) * NFSAAS-2316 R4 update packaging fixes * NFSAAS-2316 update R4 review comments Use enum for service level * NFSAAS-2316 correction to boolean usage * NFSAAS-2316 update history * NFSAAS-2316 further fixes to R4 commands * NFSAAS-2316 R4 fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.