NFSAAS-2316 update to R4 RP standard (#30) #9744
Conversation
* NFSAAS-2316 update to R4 RP standard * NFSAAS-2316 update to R4 RP standard
|
@tjprescott all the items of the linked PR (the original for the ANF CLI, #9387) should be resolved with this new PR. Could this be checked and if possible merged or feedback provided? Thanks. |
|
Actually, I've just noticed a naming issue 'azure-cli-netappfiles' should now be just 'netappfiles'. Will update. |
* NFSAAS-2316 update to R4 RP standard * NFSAAS-2316 update to R4 RP standard * NFSAAS-2316 correction to path in R4 update
* NFSAAS-2316 update to R4 RP standard * NFSAAS-2316 update to R4 RP standard * NFSAAS-2316 correction to path in R4 update * NFSAAS-2316 R4 update and structure change
|
Apologies for the multiple file deletion commits. It seems the previous PRs from my local branch when relocating the netappfiles service, did not remove the old folders. |
|
@tjprescott Any chance of another check on this? It should now be converted to the new dev structure and I hope all points from the previous PR are addressed. The RP is due to be rolled out in the next few days so I hope this can be approved and merged soon. Thanks. |
tjprescott
left a comment
tjprescott
left a comment
There was a problem hiding this comment.
There are packaging issues remaining that prevent this from being merged.
src/azure-cli/azure/cli/command_modules/netappfiles/HISTORY.rst
Outdated
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/azure-cli-netappfiles/HISTORY.rst
Outdated
Show resolved
Hide resolved
...re-cli/azure/cli/command_modules/azure-cli-netappfiles/azure/cli/command_modules/__init__.py
Outdated
Show resolved
Hide resolved
.../cli/command_modules/azure-cli-netappfiles/azure/cli/command_modules/netappfiles/__init__.py
Outdated
Show resolved
Hide resolved
...ure/cli/command_modules/azure-cli-netappfiles/azure/cli/command_modules/netappfiles/_help.py
Outdated
Show resolved
Hide resolved
* NFSAAS-2316 R4 update packaging fixes * NFSAAS-2316 update R4 review comments Use enum for service level
|
@tjprescott I'm hoping all issues are now resolved. Can this be approved and merged? |
* NFSAAS-2316 R4 update packaging fixes * NFSAAS-2316 update R4 review comments Use enum for service level * NFSAAS-2316 correction to boolean usage
* NFSAAS-2316 R4 update packaging fixes * NFSAAS-2316 update R4 review comments Use enum for service level * NFSAAS-2316 correction to boolean usage * NFSAAS-2316 update history
|
@tjprescott Is everything now ok? This is becoming quite urgent. |
* NFSAAS-2316 R4 update packaging fixes * NFSAAS-2316 update R4 review comments Use enum for service level * NFSAAS-2316 correction to boolean usage * NFSAAS-2316 update history * NFSAAS-2316 further fixes to R4 commands
|
@yugangw-msft Any chance of a review please. Note that there is a failing lint check now on code which is unchanged. Has this changed in the CI? |
|
@leonardbf yes, the CI was updated to use a newer version of pylint. Please correct the two issue and I will merge this. |
* NFSAAS-2316 R4 update packaging fixes * NFSAAS-2316 update R4 review comments Use enum for service level * NFSAAS-2316 correction to boolean usage * NFSAAS-2316 update history * NFSAAS-2316 further fixes to R4 commands * NFSAAS-2316 R4 fixes
@tjprescott ok, updated and passing |
3 participants
This PR continues the addition of the new NetAppFiles service started in the PR #9387
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).
I adhere to the Command Guidelines.