[ACR] Repository querying operations can use AAD now #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djyou
reviewed
Jan 30, 2017
There was a problem hiding this comment.
I was trying to understand the scope and repository here, does it mean if I issue a show-tags command to my repository, I will only get an access_token that has access to my repository only rather than the entire registry?
Author
There was a problem hiding this comment.
Correct. When we request an access token, we'll do so with a scope. Since reading the tags for a repository only requires pull privileges then that's what we're asking for. This is the same behavior the docker CLI has. For example, if you want to push an image, the docker CLI will request an access token with the push scope on the affected repository.
There was a problem hiding this comment.
Thanks, otherwise, this PR looks good to me. Please consider rebasing from the main repo before/after you merge, there might be some conflict in is_tty check part. /cc @sajayantony
* expose refresh token retrieving mechanism in profile * added unit tests for refresh token operations * add acr login * add the acr login command * remove print in docker login utility * fix linter errors * switch protocol to https and tweak error message * update help and readme for az login
DavidObando
force-pushed
the
daobando/aad-repo-ops
branch
2 times, most recently
from
d3c2549 to
1b18d2b
Compare
sajayantony
reviewed
Jan 30, 2017
There was a problem hiding this comment.
docker_login_to_registry [](start = 4, length = 24)
Can we move all the Docker and refresh token semantics to a _docker_utils.py or something appropriately named file?
These are alldata plane operations and so would be better to not mixing with management plane code.
DavidObando
force-pushed
the
daobando/aad-repo-ops
branch
from
1b18d2b to
4e973d3
Compare
DavidObando
force-pushed
the
daobando/aad-repo-ops
branch
from
4e973d3 to
5cf90f7
Compare
djyou
pushed a commit
that referenced
this pull request
Jul 26, 2019
* NFSAAS-2316 update to R4 RP standard (#30) * NFSAAS-2316 update to R4 RP standard (#31) * NFSAAS-2316 update to R4 RP standard * NFSAAS-2316 update to R4 RP standard * NFSAAS 2316 R4 update path correction (#32) * NFSAAS-2316 update to R4 RP standard * NFSAAS-2316 update to R4 RP standard * NFSAAS-2316 correction to path in R4 update * NFSAAS-2316 R4 update and structure change (#33) * NFSAAS-2316 update to R4 RP standard * NFSAAS-2316 update to R4 RP standard * NFSAAS-2316 correction to path in R4 update * NFSAAS-2316 R4 update and structure change * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * NFSAAS 2316 R4 update remove wheel (#34) * NFSAAS-2316 update to R4 RP standard * NFSAAS-2316 update to R4 RP standard * NFSAAS-2316 correction to path in R4 update * NFSAAS-2316 R4 update and structure change * NFSAAS-2316 update to R4 remove wheel * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * This file should have been removed in the PR #33 * NFSAAS-2316 R4 update packaging fixes (#35) * NFSAAS 2316 R4 update review comments (#36) * NFSAAS-2316 R4 update packaging fixes * NFSAAS-2316 update R4 review comments Use enum for service level * NFSAAS 2316 R4 corrections to booleans (#37) * NFSAAS-2316 R4 update packaging fixes * NFSAAS-2316 update R4 review comments Use enum for service level * NFSAAS-2316 correction to boolean usage * NFSAAS-2316 update history (#38) * NFSAAS-2316 R4 update packaging fixes * NFSAAS-2316 update R4 review comments Use enum for service level * NFSAAS-2316 correction to boolean usage * NFSAAS-2316 update history * NFSAAS-2316 R4 fixes (#39) * NFSAAS-2316 R4 update packaging fixes * NFSAAS-2316 update R4 review comments Use enum for service level * NFSAAS-2316 correction to boolean usage * NFSAAS-2316 update history * NFSAAS-2316 further fixes to R4 commands * NFSAAS-2316 R4 Fixes (#40) * NFSAAS-2316 R4 update packaging fixes * NFSAAS-2316 update R4 review comments Use enum for service level * NFSAAS-2316 correction to boolean usage * NFSAAS-2316 update history * NFSAAS-2316 further fixes to R4 commands * NFSAAS-2316 R4 fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.