Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors the test pipeline version setting mechanism by replacing a JSON string parameter with a structured array of artifact objects, enabling callers to iterate and filter artifacts more effectively.
- Replaces
ArtifactsJsonstring parameter withArtifactsobject array for better type safety and usability - Adds comprehensive validation for artifact properties (name, groupId for Java, ServiceDirectory)
- Enables per-artifact ServiceDirectory configuration while maintaining backward compatibility with the PackageNames parameter
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| eng/common/scripts/SetTestPipelineVersion.ps1 | Refactored to accept structured artifact objects instead of JSON string, added property validation, and support for per-artifact ServiceDirectory |
| eng/common/pipelines/templates/steps/set-test-pipeline-version.yml | Updated parameter type from string to object and adjusted the parameter passing to use convertToJson for the new Artifacts array |
|
The following pipelines have been queued for testing: |
|
The following pipelines have been queued for testing: |
|
The following pipelines have been queued for testing: |
|
The following pipelines have been queued for testing: |
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#13267 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) --------- Co-authored-by: ray chen <raychen@microsoft.com>
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#13267 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) --------- Co-authored-by: ray chen <raychen@microsoft.com>
raych1
changed the title
* Updated artifactJson input to artifacts input * Prioritized service directory from artifact object over the parameter input * Returned error when service directory is not provided for the old usage * Removed redudant line * Initilized the variable in a loop
3 participants
To allow iterating artifact array and filter on the value in the callers.