Conversation
azure-sdk
added
EngSys
Contributor
There was a problem hiding this comment.
Pull request overview
This PR syncs the eng/common directory with azure-sdk-tools PR #13267, refactoring the test pipeline versioning scripts to use a more type-safe approach. The main change replaces the ArtifactsJson string parameter with an Artifacts object array parameter, improving type safety and validation.
Key changes:
- Replaced
ArtifactsJsonstring parameter with strongly-typedArtifactsobject array parameter - Added comprehensive property validation for artifact objects (checking for required
name,groupId, andServiceDirectoryproperties) - Enabled per-artifact
ServiceDirectoryoverride support, falling back to the script-level parameter
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| eng/common/scripts/SetTestPipelineVersion.ps1 | Refactored to accept Artifacts object array instead of JSON string; added validation for artifact properties and ServiceDirectory handling per artifact |
| eng/common/pipelines/templates/steps/set-test-pipeline-version.yml | Updated parameter type from string to object and modified how Artifacts are passed to the PowerShell script |
azure-sdk
force-pushed
the
sync-eng/common-user/raych1/set-test-pipeline-version-change-13267
branch
from
b0698bc to
84a6b01
Compare
raych1
approved these changes
Dec 9, 2025
azure-sdk
deleted the
sync-eng/common-user/raych1/set-test-pipeline-version-change-13267
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#13267 See eng/common workflow