Conversation
azure-sdk
added
EngSys
Contributor
There was a problem hiding this comment.
Pull request overview
This PR syncs the eng/common directory with azure-sdk-tools PR #13267, refactoring how artifacts are passed to the test pipeline version setting script. The change modernizes the approach from JSON string parsing to structured object handling.
Key Changes:
- Replaced string-based
ArtifactsJsonparameter with typedArtifactsobject array for better type safety and cleaner API design - Enhanced validation logic to support per-artifact
ServiceDirectoryproperty, allowing more flexible configuration - Improved error handling with more granular validation of artifact properties (name, groupId, ServiceDirectory)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| eng/common/scripts/SetTestPipelineVersion.ps1 | Refactored to accept structured Artifacts array instead of JSON string; added per-artifact ServiceDirectory support and enhanced validation logic |
| eng/common/pipelines/templates/steps/set-test-pipeline-version.yml | Updated parameter type from string to object and modified parameter passing to use JSON conversion for the Artifacts parameter |
azure-sdk
force-pushed
the
sync-eng/common-user/raych1/set-test-pipeline-version-change-13267
branch
from
0472035 to
442811d
Compare
raych1
approved these changes
Dec 9, 2025
azure-sdk
deleted the
sync-eng/common-user/raych1/set-test-pipeline-version-change-13267
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#13267 See eng/common workflow