Conversation
azure-sdk
added
EngSys
Contributor
There was a problem hiding this comment.
Pull request overview
This PR syncs the eng/common directory with azure-sdk-tools PR #13267, refactoring how artifacts are passed to the test pipeline version setting script. The main change replaces the ArtifactsJson string parameter with a structured Artifacts object array parameter for better type safety and maintainability.
Key changes:
- Replaced string-based
ArtifactsJsonparameter with typedArtifactsobject array parameter in both PowerShell script and YAML template - Added per-artifact ServiceDirectory support, allowing individual artifacts to override the global ServiceDirectory parameter
- Enhanced validation logic with explicit property checks for required artifact fields (name, groupId for Java)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| eng/common/scripts/SetTestPipelineVersion.ps1 | Refactored parameter handling from JSON string to object array with enhanced validation, added per-artifact ServiceDirectory support, and improved error messages |
| eng/common/pipelines/templates/steps/set-test-pipeline-version.yml | Updated parameter type from string to object and modified parameter passing to convert YAML object to PowerShell array |
azure-sdk
force-pushed
the
sync-eng/common-user/raych1/set-test-pipeline-version-change-13267
branch
from
6f42aa0 to
e879077
Compare
raych1
approved these changes
Dec 9, 2025
azure-sdk
deleted the
sync-eng/common-user/raych1/set-test-pipeline-version-change-13267
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#13267 See eng/common workflow