[KeyVault] Merging preview branch keyvault_1.0_preview back to master#2817
Merged
[KeyVault] Merging preview branch keyvault_1.0_preview back to master#2817
Conversation
Updating http challenge headers for message protection
[KeyVault] Enabling message protection protocol
…into keyvault_1.0_preview
[KeyVault] updating autorest generated code from 7.0-preview spec
…into keyvault_1.0_preview
…into keyvault_1.0_preview
…into keyvault_1.0_preview
…into keyvault_1.0_preview
[KeyVault] Migrate tests and remove legacy tests.
Kv packaging
Restoring the x-ms-client-name property accidently stripped from kty on KeyProperties
[KeyVault] updating azure-keyvault and azure-mgmt-keyvault to move to release version
Contributor
|
Can one of the admins verify this patch? |
…into keyvault_1.0_preview
schaabs
force-pushed
the
keyvault_1.0_preview
branch
from
1bbb507 to
b5d7b6e
Compare
Codecov Report
@@ Coverage Diff @@
## master #2817 +/- ##
==========================================
+ Coverage 56.27% 56.65% +0.38%
==========================================
Files 7472 7598 +126
Lines 155707 157788 +2081
==========================================
+ Hits 87617 89395 +1778
- Misses 68090 68393 +303
Continue to review full report at Codecov.
|
schaabs
force-pushed
the
keyvault_1.0_preview
branch
from
4e0cd4c to
f2a92ab
Compare
…into keyvault_1.0_preview
lmazuel
approved these changes
Jun 27, 2018
Member
lmazuel
left a comment
lmazuel
left a comment
There was a problem hiding this comment.
Didn't look closely in the details, a few comments on the ChangeLog up to you
|
|
||
| Release History | ||
| =============== | ||
| 1.0.0b1 (2018-04-10) |
Member
There was a problem hiding this comment.
Should this file includes a 1.0.0 now? Even if it's just "release 1.0.0b1 as 1.0.0 unchanged"?
| 1.0.0b1 (2018-04-10) | ||
| ++++++++++++++++++++ | ||
|
|
||
| * Upgraded to autorest 3.0 generated code |
Member
There was a problem hiding this comment.
I used to copy the "General Breaking Changes" from here, to be explicit:
https://github.com/Azure/azure-sdk-for-python/blob/master/azure-sdk-tools/changelog_generics.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.