Skip to content

Comments

[KeyVault] Migrate tests and remove legacy tests.#2590

Merged
schaabs merged 2 commits intoAzure:keyvault_1.0_previewfrom
schaabs:migrate-tests
May 22, 2018
Merged

[KeyVault] Migrate tests and remove legacy tests.#2590
schaabs merged 2 commits intoAzure:keyvault_1.0_previewfrom
schaabs:migrate-tests

Conversation

@schaabs
Copy link

@schaabs schaabs commented May 19, 2018

No description provided.

@schaabs schaabs requested a review from lmazuel May 19, 2018 00:28
@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@codecov-io
Copy link

codecov-io commented May 22, 2018

Codecov Report

Merging #2590 into keyvault_1.0_preview will increase coverage by 0.1%.
The diff coverage is n/a.

Impacted file tree graph

@@                   Coverage Diff                   @@
##           keyvault_1.0_preview    #2590     +/-   ##
=======================================================
+ Coverage                 56.19%    56.3%   +0.1%     
=======================================================
  Files                      6530     6530             
  Lines                    141715   141715             
=======================================================
+ Hits                      79634    79786    +152     
+ Misses                    62081    61929    -152
Impacted Files Coverage Δ
...eyvault/azure/mgmt/keyvault/models/resource_py3.py 45.45% <0%> (-54.55%) ⬇️
...lt/models/vault_create_or_update_parameters_py3.py 55.55% <0%> (-44.45%) ⬇️
...yvault/models/vault_create_or_update_parameters.py 55.55% <0%> (-44.45%) ⬇️
...zure/mgmt/keyvault/operations/vaults_operations.py 13.51% <0%> (-34.13%) ⬇️
...ault/azure/keyvault/models/backup_secret_result.py 71.42% <0%> (-28.58%) ⬇️
...azure/keyvault/models/secret_restore_parameters.py 71.42% <0%> (-28.58%) ⬇️
...vault/azure/mgmt/keyvault/models/resource_paged.py 80% <0%> (-20%) ⬇️
...keyvault/azure/mgmt/keyvault/models/vault_paged.py 80% <0%> (-20%) ⬇️
...ure-keyvault/azure/keyvault/custom/key_vault_id.py 90.9% <0%> (+0.64%) ⬆️
azure-keyvault/azure/keyvault/key_vault_client.py 74.76% <0%> (+5.42%) ⬆️
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb30cb2...3e50c5c. Read the comment docs.

@schaabs schaabs merged commit 9e12bdb into Azure:keyvault_1.0_preview May 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants