Skip to content

[KeyVault] updating azure-keyvault and azure-mgmt-keyvault to move to release version#2807

Merged
schaabs merged 4 commits intoAzure:keyvault_1.0_previewfrom
schaabs:kv-rc
Jun 26, 2018
Merged

[KeyVault] updating azure-keyvault and azure-mgmt-keyvault to move to release version#2807
schaabs merged 4 commits intoAzure:keyvault_1.0_previewfrom
schaabs:kv-rc

Conversation

@schaabs
Copy link

@schaabs schaabs commented Jun 22, 2018

No description provided.

AutorestCI and others added 2 commits June 21, 2018 23:39
Restoring the x-ms-client-name property accidently stripped from kty on KeyProperties
@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

1 similar comment
@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@codecov-io
Copy link

codecov-io commented Jun 22, 2018

Codecov Report

Merging #2807 into keyvault_1.0_preview will increase coverage by 0.31%.
The diff coverage is 84.12%.

Impacted file tree graph

@@                   Coverage Diff                    @@
##           keyvault_1.0_preview    #2807      +/-   ##
========================================================
+ Coverage                 55.97%   56.28%   +0.31%     
========================================================
  Files                      7249     7265      +16     
  Lines                    152276   152432     +156     
========================================================
+ Hits                      85232    85794     +562     
+ Misses                    67044    66638     -406
Impacted Files Coverage Δ
...ult/azure/keyvault/models/key_create_parameters.py 100% <ø> (ø) ⬆️
...azure/keyvault/models/key_verify_parameters_py3.py 100% <ø> (+44.44%) ⬆️
...keyvault/azure/keyvault/models/json_web_key_py3.py 100% <ø> (+80.95%) ⬆️
...azure/keyvault/models/key_create_parameters_py3.py 100% <ø> (+58.33%) ⬆️
...ult/azure/keyvault/models/key_verify_parameters.py 100% <ø> (ø) ⬆️
...t/azure/keyvault/models/key_sign_parameters_py3.py 100% <ø> (+37.5%) ⬆️
...ure-keyvault/azure/keyvault/models/json_web_key.py 100% <ø> (ø) ⬆️
...vault/azure/keyvault/models/key_sign_parameters.py 100% <ø> (ø) ⬆️
azure-mgmt-keyvault/azure/mgmt/keyvault/version.py 100% <100%> (ø) ⬆️
...ult/azure/keyvault/models/secret_attributes_py3.py 100% <100%> (+28.57%) ⬆️
... and 104 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ed3e54...8293098. Read the comment docs.

@schaabs schaabs requested a review from tiffanyachen June 22, 2018 23:23
@schaabs schaabs changed the title [KeyVault] updating data-plane SDK and move to release version [KeyVault] updating azure-keyvault and azure-mgmt-keyvault to move to release version Jun 26, 2018


class KeyVaultClient(object):
class KeyVaultClient(SDKClient):
Copy link
Member

@lmazuel lmazuel Jun 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@schaabs If you wonder what this is, I write that in my ChangeLog for this Autorest change:

Client class can be used as a context manager to keep the underlying HTTP session open for performance

Which means that this:

with KeyVaultClient(params) as kv:
    kv.do_somthing()

will keep the same requests.Session object for the life of the with, and might improve a lot performance.
Note that in future async SDK, this syntax will be required since aiohttp force the with syntax (it's one of the reason I introduced it, I make the code more and more compatible with async so the switch is simple eventually).

@schaabs schaabs merged commit fd71e24 into Azure:keyvault_1.0_preview Jun 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

Comments