[KeyVault] updating azure-keyvault and azure-mgmt-keyvault to move to release version#2807
Conversation
Restoring the x-ms-client-name property accidently stripped from kty on KeyProperties
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
Codecov Report
Continue to review full report at Codecov.
|
|
|
||
|
|
||
| class KeyVaultClient(object): | ||
| class KeyVaultClient(SDKClient): |
There was a problem hiding this comment.
@schaabs If you wonder what this is, I write that in my ChangeLog for this Autorest change:
Client class can be used as a context manager to keep the underlying HTTP session open for performance
Which means that this:
with KeyVaultClient(params) as kv:
kv.do_somthing()
will keep the same requests.Session object for the life of the with, and might improve a lot performance.
Note that in future async SDK, this syntax will be required since aiohttp force the with syntax (it's one of the reason I introduced it, I make the code more and more compatible with async so the switch is simple eventually).
No description provided.