Skip to content

[KeyVault] Enabling message protection protocol#1828

Merged
schaabs merged 20 commits intoAzure:keyvault_1.0_previewfrom
schaabs:mcrypt
Jan 25, 2018
Merged

[KeyVault] Enabling message protection protocol#1828
schaabs merged 20 commits intoAzure:keyvault_1.0_previewfrom
schaabs:mcrypt

Conversation

@schaabs
Copy link

@schaabs schaabs commented Jan 24, 2018

The changes in this pull request enable the message protection protocol, which is needed to perform key operations against vaults with message protection enabled.

The changes in this pull request have been previously reviewed here: #1686

@schaabs schaabs requested a review from lmazuel as a code owner January 24, 2018 21:51
@lmazuel
Copy link
Member

lmazuel commented Jan 24, 2018

@schaabs Please rebase your fork branch on top of keyvault_1.0_preview to avoid the swagger_to_sdk.config.json conflict

@jaredmoo
Copy link
Contributor

Can you clarify why the SQL setup change is needed? Thx :)

@lmazuel
Copy link
Member

lmazuel commented Jan 24, 2018

@jaredmoo It's not, for some reason Github triggered a review from you, where you just owner of "azure-mgmt-sql". Too much git magic rebase :)

Copy link
Member

@lmazuel lmazuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

codecov-io commented Jan 25, 2018

Codecov Report

Merging #1828 into keyvault_1.0_preview will increase coverage by 0.06%.
The diff coverage is 68.62%.

Impacted file tree graph

@@                   Coverage Diff                    @@
##           keyvault_1.0_preview    #1828      +/-   ##
========================================================
+ Coverage                 52.81%   52.88%   +0.06%     
========================================================
  Files                      4579     4582       +3     
  Lines                    112596   113013     +417     
========================================================
+ Hits                      59469    59764     +295     
- Misses                    53127    53249     +122
Impacted Files Coverage Δ
azure-keyvault/azure/keyvault/__init__.py 100% <100%> (ø) ⬆️
azure-keyvault/azure/keyvault/version.py 100% <100%> (ø) ⬆️
...ult/azure/keyvault/custom/http_message_security.py 21.51% <21.51%> (ø)
.../azure/keyvault/custom/key_vault_authentication.py 45.79% <48.97%> (+6.77%) ⬆️
...e-keyvault/azure/keyvault/custom/http_challenge.py 78.46% <78.46%> (ø)
azure-keyvault/azure/keyvault/custom/internal.py 84.55% <84.55%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14b51c2...849f57d. Read the comment docs.

@schaabs schaabs merged commit 6e610ff into Azure:keyvault_1.0_preview Jan 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants