Skip to content

Comments

[formrecognizer] Adding to_dict() on custom models#18402

Merged
catalinaperalta merged 10 commits intoAzure:masterfrom
catalinaperalta:master
May 7, 2021
Merged

[formrecognizer] Adding to_dict() on custom models#18402
catalinaperalta merged 10 commits intoAzure:masterfrom
catalinaperalta:master

Conversation

@catalinaperalta
Copy link
Member

@catalinaperalta catalinaperalta commented Apr 28, 2021

Fixes in part #18318

@kristapratico
Copy link
Contributor

kristapratico commented Apr 29, 2021

PR adding the remaining to_dict()'s is here: catalinaperalta#3

@check-enforcer
Copy link

check-enforcer bot commented May 4, 2021

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run python - [service] - ci

@catalinaperalta catalinaperalta marked this pull request as ready for review May 4, 2021 20:17
kristapratico
kristapratico reviewed May 5, 2021
View reviewed changes
Copy link
Contributor

@kristapratico kristapratico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Some small things. Thanks for all your work :)

@catalinaperalta catalinaperalta merged commit cc3c34d into Azure:master May 7, 2021
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request May 7, 2021
@iscai-msft
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-python …
a662818 
…into azure_purview_scanning

* 'master' of https://github.com/Azure/azure-sdk-for-python: (31 commits)
  [purview] add catalog client (Azure#17788)
  Add spellcheck for modified files (Azure#18496)
  [Container Registry] Update API for Beta 2 (Azure#18392)
  First version of Confidential Ledger Python SDK (Azure#17951)
  [llc] add quickstart (Azure#18537)
  [Storage][Fix]Copy source is redirecting (Azure#18577)
  [Tables] pre-release script (Azure#18505)
  Update changelogs (Azure#18575)
  [formrecognizer] Adding to_dict() on custom models (Azure#18402)
  Raise CredentialUnavailableError when CLI subprocess times out (Azure#18509)
  Extend Check Enforcer timeout (Azure#18526)
  Core raw streaming (Azure#17920)
  hide secrets in mgmt sdk (Azure#18535)
  add filter samples for list methods (Azure#18480)
  Revert changes to SetDevVersion. (Azure#18555)
  add support for filtering/paging/sorting options for "list_**" methods (Azure#18302)
  [Tables] Misc client updates (Azure#18462)
  [EventHub&ServiceBus] Prepare for release (Azure#18527)
  [Communication]: Updated communication connection strings to be consistent across packages and languages (Azure#18519)
  [AppConfig] Fixing samples (Azure#18542)
  ...
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request May 7, 2021
@iscai-msft
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-python …
ee40824 
…into agrifood_nspkg

* 'master' of https://github.com/Azure/azure-sdk-for-python: (31 commits)
  [purview] add catalog client (Azure#17788)
  Add spellcheck for modified files (Azure#18496)
  [Container Registry] Update API for Beta 2 (Azure#18392)
  First version of Confidential Ledger Python SDK (Azure#17951)
  [llc] add quickstart (Azure#18537)
  [Storage][Fix]Copy source is redirecting (Azure#18577)
  [Tables] pre-release script (Azure#18505)
  Update changelogs (Azure#18575)
  [formrecognizer] Adding to_dict() on custom models (Azure#18402)
  Raise CredentialUnavailableError when CLI subprocess times out (Azure#18509)
  Extend Check Enforcer timeout (Azure#18526)
  Core raw streaming (Azure#17920)
  hide secrets in mgmt sdk (Azure#18535)
  add filter samples for list methods (Azure#18480)
  Revert changes to SetDevVersion. (Azure#18555)
  add support for filtering/paging/sorting options for "list_**" methods (Azure#18302)
  [Tables] Misc client updates (Azure#18462)
  [EventHub&ServiceBus] Prepare for release (Azure#18527)
  [Communication]: Updated communication connection strings to be consistent across packages and languages (Azure#18519)
  [AppConfig] Fixing samples (Azure#18542)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iscai-msft iscai-msft Awaiting requested review from iscai-msft

1 more reviewer

@kristapratico kristapratico kristapratico approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Cognitive - Form Recognizer

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@catalinaperalta @kristapratico