add to_dict to models#3
Merged
catalinaperalta merged 1 commit intocatalinaperalta:masterfrom May 3, 2021
Merged
Conversation
| "unit": self.unit, | ||
| "tables": [ | ||
| table.to_dict() for table in self.tables | ||
| ] if self.tables else None, |
Owner
There was a problem hiding this comment.
Nice! I like this, I'll do something similar in mine.
catalinaperalta
pushed a commit
that referenced
this pull request
Jun 24, 2022
* Initial commit * Copied shared files * Added basic functionality to the sip client. * Copied shared folder to get the utilities. Implemented sample files. Changed naming in client * Modified function comments and added class comment for _sip_routing_client. * Fixed kwargs propagation * Changed sample file to pull parameteres from environment variables. * Changed get SIP configuration sample to be a class to align with the update samples. Changed naming of the update samples class. * Implemented basic tests for the SIP client * Removed unused import * Fixed comment. * Renamed variables dut_client to test_client. * Merge from original repo * Feature/communication sip configuration dev/basic client functionality (#3) Adding async client. * Updated from original (Azure#4) Updated from main repo. * Fixing pylint * Changed value error to be compatible with python 2. * Reverted changes for pylint. * Fixed dev requirements and MANIFEST * Fixing async tests. Fixing comments. * Removed async mock to be compatible with the builds. * Fixing test failures for Ubuntu and Mac * Changed versions for python. Fixed pylint issue in version. * Modified _version file to prevent path errors. * Added newline. * Downgraded six version to match the frozen requirements. * Fixed async test errors by excluding asynchronous tests for python 2.7. * Regenerated by autorest * Updated swagger definition. * Squashed commit of the following: commit 3d7c16a5355a6461a4e688e89410a735dfdcfcce Author: Jiri Burant <83883278+jiriburant@users.noreply.github.com> Date: Mon Jun 7 17:50:06 2021 +0200 Added e2e and recordings of the tests. commit 3f92f30afc5e932b2834a337401f51231abfb602 Author: Jiri Burant <83883278+jiriburant@users.noreply.github.com> Date: Mon Jun 7 17:39:44 2021 +0200 Renamed communication testcase and async communication testcase. commit 6f92a5aaf37c94878aedbfa4a505282e17041ff8 Author: Jiri Burant <83883278+jiriburant@users.noreply.github.com> Date: Mon Jun 7 17:25:47 2021 +0200 Fixed sanitized url to have .net instead of .com . commit 6e1ab5e228452b3bb29d9ec01b13a779cb6103c2 Author: Jiri Burant <83883278+jiriburant@users.noreply.github.com> Date: Mon Jun 7 17:25:04 2021 +0200 Fixed async client to have all the needed asynchronous behaviour commit a3ce07361fbab9f0fb335cd35379009486382786 Author: Jiri Burant <83883278+jiriburant@users.noreply.github.com> Date: Mon Jun 7 09:23:29 2021 +0200 Split the testcase and request replacer processor into two files. commit 26026c256bff0cd186f38656e0477f466e7e5d02 Author: Jiri Burant <83883278+jiriburant@users.noreply.github.com> Date: Mon Jun 7 08:18:44 2021 +0200 Modified paths to fake credential tokens to reflect teh changed naming. commit fdda1dd10f57b1f67a354fc844b8f5346d1ba200 Author: Jiri Burant <83883278+jiriburant@users.noreply.github.com> Date: Mon Jun 7 08:17:29 2021 +0200 Added dev requirement commit 2967dff8a91067cacdf34fb3047e5a992be1721b Author: Jiri Burant <83883278+jiriburant@users.noreply.github.com> Date: Mon Jun 7 08:17:10 2021 +0200 Renamed mocks to testcases commit 16b55c29ba7570d00e4ed1780f60da83e852258d Author: Jiri Burant <83883278+jiriburant@users.noreply.github.com> Date: Fri Jun 4 11:38:12 2021 +0200 Renamed variable names for sip configuration commit 63b338e3ea22e6a9c691e7a4f42663d03af5756c Author: Jiri Burant <83883278+jiriburant@users.noreply.github.com> Date: Fri Jun 4 10:45:37 2021 +0200 Renamed methods of sip routing client commit f709b26d646df3b9b98506af22185d800c02234a Author: Jiri Burant <83883278+jiriburant@users.noreply.github.com> Date: Fri Jun 4 10:20:49 2021 +0200 Modified clients to allow for credentials. commit ea8d1323fcfa069e066d52521a4f08f08dffe871 Author: Jiri Burant <83883278+jiriburant@users.noreply.github.com> Date: Fri Jun 4 10:14:02 2021 +0200 Initial Readms * Fixed readme links and formatting. Added sdk_moniker for client * Refactored authentication files. AAdded response sanitization. * Fixed linting issues. * Modified version to beta. * Regenerated swagger with latest definitions, implemented missing async sample files. * Fixing lint issues. * Fixed pylint disable comment. * Renamed sip routing client to match the conventions and updated tests. * Removed -Patch from public namespace. * Addressing comments from api review * Removed older files in separate package * Updated version for azure.core to support newly generated code. * Implemented swagger definition for SIP routing * Implemented SIP routing logic * Implemented siprouting changes * Added new types to public package * Changed phone numbers test to work with package structure * prepared recordings for sip routing * Added internal and public version of SipTrunk to accomodate for fqdn parameter. Changed public client interface to have functions separately for trunks/routes. * Fixing formatting. * Changed public interface. * Recordings of e2e tests. * Addressing comments from second internal review. * Minor changes in cleaning up code. Added a few sample calls. * Added test for token auth * Implemented inputs from api review * Fixed linting issues and credential issues. * Fixed test recordings. * Removed test credentials. * Moved siprouting tests to common namespace and removed packaging on tests. * Changed token authorization test to work in recorded mode. Fixed dependencies in setup.py file * Restored setup.py file to avoid package clashes. * Regenerated code with lower version of autorest to pass build validation. * Renamed replace_trunks and replace_routes to set_trunks, set_routes * Renamed recordings of tests. * Added more tests for managed identity. Updated README and Changelog. * Updated version. * Addressing comments from review. * Removing forgotten credential. * Addressing comments from review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sorry for the delay, no tests yet - just wanted to unblock you on FormPage