Merged
Conversation
Contributor
Author
xiangyan99
reviewed
May 6, 2021
| @@ -24,16 +24,18 @@ async def handle_event_grid_notifications(event_grid_events): | |||
|
|
|||
| all_keys = [] | |||
|
|
|||
| async with AzureAppConfigurationClient.from_connection_string(CONNECTION_STRING) as client: | |||
Member
There was a problem hiding this comment.
This will cause connection unclose.
We recommend users to use context manager to close client.
Contributor
Author
There was a problem hiding this comment.
There is no __enter__ (or __aenter__ in async) on the clients. Adding this now.
|
Hello @seankane-msft! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
xiangyan99
approved these changes
May 6, 2021
ghost
merged commit
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
May 7, 2021
…into azure_purview_scanning * 'master' of https://github.com/Azure/azure-sdk-for-python: (31 commits) [purview] add catalog client (Azure#17788) Add spellcheck for modified files (Azure#18496) [Container Registry] Update API for Beta 2 (Azure#18392) First version of Confidential Ledger Python SDK (Azure#17951) [llc] add quickstart (Azure#18537) [Storage][Fix]Copy source is redirecting (Azure#18577) [Tables] pre-release script (Azure#18505) Update changelogs (Azure#18575) [formrecognizer] Adding to_dict() on custom models (Azure#18402) Raise CredentialUnavailableError when CLI subprocess times out (Azure#18509) Extend Check Enforcer timeout (Azure#18526) Core raw streaming (Azure#17920) hide secrets in mgmt sdk (Azure#18535) add filter samples for list methods (Azure#18480) Revert changes to SetDevVersion. (Azure#18555) add support for filtering/paging/sorting options for "list_**" methods (Azure#18302) [Tables] Misc client updates (Azure#18462) [EventHub&ServiceBus] Prepare for release (Azure#18527) [Communication]: Updated communication connection strings to be consistent across packages and languages (Azure#18519) [AppConfig] Fixing samples (Azure#18542) ...
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
May 7, 2021
…into agrifood_nspkg * 'master' of https://github.com/Azure/azure-sdk-for-python: (31 commits) [purview] add catalog client (Azure#17788) Add spellcheck for modified files (Azure#18496) [Container Registry] Update API for Beta 2 (Azure#18392) First version of Confidential Ledger Python SDK (Azure#17951) [llc] add quickstart (Azure#18537) [Storage][Fix]Copy source is redirecting (Azure#18577) [Tables] pre-release script (Azure#18505) Update changelogs (Azure#18575) [formrecognizer] Adding to_dict() on custom models (Azure#18402) Raise CredentialUnavailableError when CLI subprocess times out (Azure#18509) Extend Check Enforcer timeout (Azure#18526) Core raw streaming (Azure#17920) hide secrets in mgmt sdk (Azure#18535) add filter samples for list methods (Azure#18480) Revert changes to SetDevVersion. (Azure#18555) add support for filtering/paging/sorting options for "list_**" methods (Azure#18302) [Tables] Misc client updates (Azure#18462) [EventHub&ServiceBus] Prepare for release (Azure#18527) [Communication]: Updated communication connection strings to be consistent across packages and languages (Azure#18519) [AppConfig] Fixing samples (Azure#18542) ...
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.