add support for filtering/paging/sorting options for "list_**" methods by mshaban-msft · Pull Request #18302 · Azure/azure-sdk-for-python

mshaban-msft · 2021-04-26T15:03:30Z

solves #17679

kristapratico

Nice job! 😎 Most of the feedback applies broadly

sdk/translation/azure-ai-translation-document/azure/ai/translation/document/_client.py

sdk/translation/azure-ai-translation-document/tests/test_all_document_statuses.py

sdk/translation/azure-ai-translation-document/tests/test_list_submitted_jobs.py

sdk/translation/azure-ai-translation-document/tests/testcase.py

check-enforcer · 2021-04-29T01:22:31Z

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run python - [service] - ci

mshaban-msft · 2021-04-30T20:48:14Z

@kristapratico
i finished the tests for list all jobs (both sync and async)
had to label some tests with the annotation 'skip'
you can see the message on each
please let me know what you think

sdk/translation/azure-ai-translation-document/azure/ai/translation/document/_client.py

sdk/translation/azure-ai-translation-document/tests/test_list_submitted_jobs.py

sdk/translation/azure-ai-translation-document/azure/ai/translation/document/_client.py

sdk/translation/azure-ai-translation-document/tests/test_all_document_statuses.py

sdk/translation/azure-ai-translation-document/tests/test_list_submitted_jobs.py

… list

kristapratico

@mohamedshabanofficial The CI failures seem to be a problem with the recording processor and how it is encoding the datetime in the URL. Since the tests are fine to run live, let's just add a @pytest.mark.live_test_only decorator to the ones that are failing. That should get the PR green so we can merge :)

…into azure_purview_scanning * 'master' of https://github.com/Azure/azure-sdk-for-python: (31 commits) [purview] add catalog client (Azure#17788) Add spellcheck for modified files (Azure#18496) [Container Registry] Update API for Beta 2 (Azure#18392) First version of Confidential Ledger Python SDK (Azure#17951) [llc] add quickstart (Azure#18537) [Storage][Fix]Copy source is redirecting (Azure#18577) [Tables] pre-release script (Azure#18505) Update changelogs (Azure#18575) [formrecognizer] Adding to_dict() on custom models (Azure#18402) Raise CredentialUnavailableError when CLI subprocess times out (Azure#18509) Extend Check Enforcer timeout (Azure#18526) Core raw streaming (Azure#17920) hide secrets in mgmt sdk (Azure#18535) add filter samples for list methods (Azure#18480) Revert changes to SetDevVersion. (Azure#18555) add support for filtering/paging/sorting options for "list_**" methods (Azure#18302) [Tables] Misc client updates (Azure#18462) [EventHub&ServiceBus] Prepare for release (Azure#18527) [Communication]: Updated communication connection strings to be consistent across packages and languages (Azure#18519) [AppConfig] Fixing samples (Azure#18542) ...

…into agrifood_nspkg * 'master' of https://github.com/Azure/azure-sdk-for-python: (31 commits) [purview] add catalog client (Azure#17788) Add spellcheck for modified files (Azure#18496) [Container Registry] Update API for Beta 2 (Azure#18392) First version of Confidential Ledger Python SDK (Azure#17951) [llc] add quickstart (Azure#18537) [Storage][Fix]Copy source is redirecting (Azure#18577) [Tables] pre-release script (Azure#18505) Update changelogs (Azure#18575) [formrecognizer] Adding to_dict() on custom models (Azure#18402) Raise CredentialUnavailableError when CLI subprocess times out (Azure#18509) Extend Check Enforcer timeout (Azure#18526) Core raw streaming (Azure#17920) hide secrets in mgmt sdk (Azure#18535) add filter samples for list methods (Azure#18480) Revert changes to SetDevVersion. (Azure#18555) add support for filtering/paging/sorting options for "list_**" methods (Azure#18302) [Tables] Misc client updates (Azure#18462) [EventHub&ServiceBus] Prepare for release (Azure#18527) [Communication]: Updated communication connection strings to be consistent across packages and languages (Azure#18519) [AppConfig] Fixing samples (Azure#18542) ...

mshaban-msft requested a review from kristapratico as a code owner April 26, 2021 15:03

kristapratico requested a review from maririos April 26, 2021 18:18

kristapratico reviewed Apr 26, 2021

View reviewed changes

kristapratico reviewed May 1, 2021

View reviewed changes

MIDDLEEAST\v-moshaban added 24 commits May 3, 2021 15:56

update method docstrings

0cb681d

added tests for list jobs

9e6ec78

updated tests for list docs statuses

0991aeb

added async tests for job listing

7c47d29

update old async tests 'list doc statuses'

0cf21f6

fixing some errors

29c7770

bug fix async code

7cae6cd

added async tests for 'list all doc statuses'

d43d097

update docstrings for list_submitted_jobs

222ce25

add time convert helper

ef0a953

update async client

82f4c7f

updated 'list_document_statuses'

d09554d

fix paging issues

b1611ea

fix artifact parameter names in tests

24f790d

remove unwanted tests

6593ac8

fix order_by parameters

50f7f7d

fix test function names

f62a16a

remove unwanted imports from tests

3256621

fix kwargs parm name

bf530d1

fix test list jobs before datetime

331cc71

bug fixes

99be798

fixed some tests

58b8260

updated tests

b6c303e

update async tests

bac7e23

MIDDLEEAST\v-moshaban added 7 commits May 3, 2021 16:03

skip tests

aca9dfc

temp commit

8f25b0f

updated tests for "list all document statuses" sync client

5e4a006

updated async tests

d68434c

spelling mistakes

a460453

update id parameter name

8c73126

fix 'skip' test

f0290ae

mshaban-msft force-pushed the 17679/add_filters_flattened branch from d8cfb59 to f0290ae Compare May 3, 2021 14:07

mshaban-msft changed the title ~~17679/add filters flattened~~ add filters flattened May 3, 2021

mshaban-msft changed the title ~~add filters flattened~~ add support for filtering/paging/sorting options for "list_**" methods May 3, 2021

MIDDLEEAST\v-moshaban added 6 commits May 3, 2021 16:31

fixed filter by status test

6bfe5ed

fix filtering by 'created_before' tests

4ec7400

fix linting errors

23e12b5

fix async test

f549970

add support for pytz in tests

a864cc5

update mixed tests for 'list_submitted_jobs'

20b451b

kristapratico reviewed May 3, 2021

View reviewed changes

MIDDLEEAST\v-moshaban added 7 commits May 4, 2021 21:50

PR comments - speccling mistakes

4bafd71

PR reviews - min and max errors

1e895a3

updated mixed-filter tests. still not working!

1ed1c32

fixed bug with converting page to list then calling iterator on empty…

6f1fb5d

… list

fix await problem in async test

e906111

adding recorded tests

6e573e0

white space -> trigger ci/cd pipeline

a9f1281

kristapratico approved these changes May 6, 2021

View reviewed changes

MIDDLEEAST\v-moshaban added 2 commits May 6, 2021 22:39

update time-baesd failing tests with decorator

1c0e1b5

update recorded tests

5e1f1b0

kristapratico merged commit 9b79695 into Azure:master May 6, 2021

Comments

Conversation

mshaban-msft commented Apr 26, 2021

Uh oh!

kristapratico left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

check-enforcer bot commented Apr 29, 2021

What is Check Enforcer?

Why am I getting this message?

What should I do now?

What if I am onboarding a new service?

Uh oh!

mshaban-msft commented Apr 30, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kristapratico left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants