Azure.Core 2.0/System.ClientModel Integration#41773
Closed
annelo-msft wants to merge 59 commits intoAzure:mainfrom
Closed
Azure.Core 2.0/System.ClientModel Integration#41773annelo-msft wants to merge 59 commits intoAzure:mainfrom
annelo-msft wants to merge 59 commits intoAzure:mainfrom
Conversation
annelo-msft
commented
Feb 3, 2024
annelo-msft
commented
Feb 3, 2024
sdk/core/Azure.Core/src/Pipeline/HttpClientTransport.Adapter.cs
Outdated
Show resolved
Hide resolved
annelo-msft
commented
Feb 3, 2024
annelo-msft
commented
Feb 3, 2024
annelo-msft
commented
Feb 3, 2024
annelo-msft
commented
Feb 3, 2024
annelo-msft
commented
Feb 3, 2024
annelo-msft
commented
Feb 3, 2024
annelo-msft
commented
Feb 3, 2024
annelo-msft
commented
Feb 3, 2024
Collaborator
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
annelo-msft
commented
Feb 28, 2024
sdk/core/Azure.Core/src/Response.cs
Outdated
| => new AzureCoreResponse<T>(value, response); | ||
|
|
||
| /// <summary> | ||
| /// Returns the string representation of this <see cref="Response"/>. |
Member
Author
There was a problem hiding this comment.
TODO: Remove DisposeStreamIfNotBuffered when we update the transport response implementations.
annelo-msft
commented
Feb 28, 2024
sdk/core/Azure.Core/src/Pipeline/Internal/HttpPipelineTransportPolicy.cs
Outdated
Show resolved
Hide resolved
annelo-msft
added a commit
to annelo-msft/azure-sdk-for-net
that referenced
this pull request
Mar 1, 2024
annelo-msft
added a commit
that referenced
this pull request
Mar 1, 2024
…d transport types (#42294) * initial checkin * WIP * Tables * updates * Add tests * updates * API updates * Add ResponseHeadersAdapter * rework buffering a bit * revert * reshuffle * fix * add tests * nits * nits * Initial files * fix build * update comment on NullableResponse<T>.DefaultResponse * nits * use default * Allow setting message.ResponseClassifier from the base type property * update exception text * add test that fails if classifier TryClassify methods are unsealed * updates * remove NetworkTimeout logic until we can implement it e2e * remove NetworkTimeout logic until we can implement it e2e * add comment to adapter * address PR feedback * Initial checkin for policy only * updates from PR feedback * make HttpPipelineTransport inherit from PipelineTransport * export API * move to full transport implementation * address feedback from #41773 * fix and export API * update adapter comment based on pr fb * Initial files * call through to response.Headers.Set * update DigitalTwins with RFE refdoc changes * add refdoc for RFE
Member
Author
|
Closing in favor of #42386 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After System.ClientModel GA's, we will update Azure.Core types to use functional implementations that have moved into System.ClientModel types, either by having the Azure.Core type inherit from the corresponding System.ClientModel type, or by internally adapting the System.ClientModel type to the Azure.Core behavior and calling through to the System.ClientModel implementation.
This PR implements the changes to Azure.Core to use functionality implemented in System.ClientModel. It also updates the System.ClientModel test project containing types like models that simulate client types to use nullable annotations for reference types, which will be enabled for ClientModel-based clients so that they can return ClientResult<T?> to indicate that a model is optional on the response.
Azure.Core APIView diff with ClientModel integration
System.ClientModel APIView diff from main <-- no differences