Azure.Core 2.0: Update Response, Response<T>, and NullableResponse<T>#42255
Merged
annelo-msft merged 17 commits intoAzure:feature/azure.core-2.0from Feb 28, 2024
Merged
Azure.Core 2.0: Update Response, Response<T>, and NullableResponse<T>#42255annelo-msft merged 17 commits intoAzure:feature/azure.core-2.0from
annelo-msft merged 17 commits intoAzure:feature/azure.core-2.0from
Conversation
annelo-msft
commented
Feb 28, 2024
annelo-msft
commented
Feb 28, 2024
annelo-msft
commented
Feb 28, 2024
annelo-msft
commented
Feb 28, 2024
annelo-msft
commented
Feb 28, 2024
annelo-msft
added a commit
to annelo-msft/azure-sdk-for-net
that referenced
this pull request
Feb 28, 2024
Collaborator
|
API change check API changes are not detected in this pull request. |
christothes
reviewed
Feb 28, 2024
Member
Author
|
Discussed offline that this is OK to merge - we may revisit the internal DefaultResponse class if there is another way to address the need of ClientResult to get a non-null Response from the NullableResponse<T> default constructor. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Many of the basic Azure.Core types now have analogous types in the System.ClientModel library. In order to follow the DRY engineering principle, we plan to update Azure.Core to reuse functionality from these types, using either inheritance or adapters in most cases.
This PR makes the following changes:
Responseinherits from System.ClientModelPipelineResponseNullableResponse<T>inherits from System.ClientModelClientResult<T?>Design Motivation
Despite some complexity in the implementation of the inheritance of
ResponsefromPipelineResponse, this is required in order to be able to write a single pipeline policy that will work in both Azure.Core and System.ClientModel pipelines.Context
This PR is a smaller chunk of #41773 to make it easier to review. In addition, it this PR targets the feature/azure.core-2.0 feature branch because we cannot move the Azure.Core 2.0 integration into main until after System.ClientModel 1.1.0 is GA.