Azure.Core 2.0: Update RequestFailedException#42323
Closed
annelo-msft wants to merge 42 commits intoAzure:feature/azure.core-2.0from
Closed
Azure.Core 2.0: Update RequestFailedException#42323annelo-msft wants to merge 42 commits intoAzure:feature/azure.core-2.0from
annelo-msft wants to merge 42 commits intoAzure:feature/azure.core-2.0from
Conversation
Collaborator
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
Member
Author
|
Closing in favor of #42294 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Many of the basic Azure.Core types now have analogous types in the System.ClientModel library. In order to follow the DRY engineering principle, we plan to update Azure.Core to reuse functionality from these types, using either inheritance or adapters in most cases.
This PR makes the following changes:
RequestFailedExceptioninherits from System.ClientModelClientRequestExceptionDesign Motivation
Inheritance is required for this type to enable common exception handling.
Context
This PR is a smaller chunk of #41773 to make it easier to review. In addition, it this PR targets the feature/azure.core-2.0 feature branch because we cannot move the Azure.Core 2.0 integration into main until after System.ClientModel 1.1.0 is GA.