Skip to content

feature/azure.core-2.0#42386

Closed
annelo-msft wants to merge 8 commits intomainfrom
feature/azure.core-2.0
Closed

feature/azure.core-2.0#42386
annelo-msft wants to merge 8 commits intomainfrom
feature/azure.core-2.0

Conversation

@annelo-msft
Copy link
Member

This PR implements the integration of Azure.Core 2.0 with the System.ClientModel library.

It replaces earlier PRs that implemented this at various points in the development of System.ClientModel, including #41773 and #39135.

* Initial files

* nits

* export API

* refactor Request to simplify a bit

* add comments

* update

* fix build

* nits

* update

* updates

* Add test for JsonModel RequestContent

* Adapt to RequestContent when ContentCore is set to BinaryContent base type instance

* remove WireOptions

* add tests for base type assignment scenarios
…#42255)

* initial checkin

* WIP

* Tables

* updates

* Add tests

* updates

* API updates

* Add ResponseHeadersAdapter

* rework buffering a bit

* revert

* reshuffle

* fix

* add tests

* nits

* nits

* update comment on NullableResponse<T>.DefaultResponse
…tions (#42262)

* initial checkin

* WIP

* Tables

* updates

* Add tests

* updates

* API updates

* Add ResponseHeadersAdapter

* rework buffering a bit

* revert

* reshuffle

* fix

* add tests

* nits

* nits

* Initial files

* fix build

* update comment on NullableResponse<T>.DefaultResponse

* nits

* use default

* Allow setting message.ResponseClassifier from the base type property

* update exception text

* add test that fails if classifier TryClassify methods are unsealed

* updates

* remove NetworkTimeout logic until we can implement it e2e

* remove NetworkTimeout logic until we can implement it e2e

* add comment to adapter

* address PR feedback

* updates from PR feedback
…d transport types (#42294)

* initial checkin

* WIP

* Tables

* updates

* Add tests

* updates

* API updates

* Add ResponseHeadersAdapter

* rework buffering a bit

* revert

* reshuffle

* fix

* add tests

* nits

* nits

* Initial files

* fix build

* update comment on NullableResponse<T>.DefaultResponse

* nits

* use default

* Allow setting message.ResponseClassifier from the base type property

* update exception text

* add test that fails if classifier TryClassify methods are unsealed

* updates

* remove NetworkTimeout logic until we can implement it e2e

* remove NetworkTimeout logic until we can implement it e2e

* add comment to adapter

* address PR feedback

* Initial checkin for policy only

* updates from PR feedback

* make HttpPipelineTransport inherit from PipelineTransport

* export API

* move to full transport implementation

* address feedback from #41773

* fix and export API

* update adapter comment based on pr fb

* Initial files

* call through to response.Headers.Set

* update DigitalTwins with RFE refdoc changes

* add refdoc for RFE
…eClassifier (#42329)

* Initial check-in

* export API

* update samples

* updates to RetryPolicy

* nits and export API

* Add TextAnalytics exception parser

* update RetryOptions with defaults

* pr fb: change retry policy exception to debug.assert
@azure-sdk
Copy link
Collaborator

azure-sdk commented Mar 5, 2024

API change check

API changes are not detected in this pull request.

@annelo-msft
Copy link
Member Author

Feedback on this from @AlexanderSher: #42328 (comment)

@github-actions
Copy link

Hi @annelo-msft. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

@github-actions github-actions bot added the no-recent-activity There has been no recent activity on this issue. label May 10, 2024
@annelo-msft
Copy link
Member Author

Don't close

@github-actions github-actions bot removed the no-recent-activity There has been no recent activity on this issue. label May 10, 2024
@github-actions
Copy link

Hi @annelo-msft. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

@github-actions github-actions bot added the no-recent-activity There has been no recent activity on this issue. label Jul 12, 2024
@github-actions
Copy link

Hi @annelo-msft. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing /reopen if you'd like to continue working on these changes. Please be sure to use the command to reopen or remove the no-recent-activity label; otherwise, this is likely to be closed again with the next cleanup pass.

@github-actions github-actions bot closed this Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants