Skip to content

Merged ADMS changes for Nov. SDK release#3824

Merged
markcowl merged 1 commit intoAzure:psSdkJson6from
gadongji:adfChangesForOctRelease
Oct 31, 2017
Merged

Merged ADMS changes for Nov. SDK release#3824
markcowl merged 1 commit intoAzure:psSdkJson6from
gadongji:adfChangesForOctRelease

Conversation

@gadongji
Copy link
Copy Markdown

Description

This is a merged PR for three SDK changes from ADMS side.
Related features and corresponding swagger changes, SDK changes and internal items are:

AzureMySql connector:
[Swagger PR] Azure/azure-rest-api-specs#1911
[Internal item] 97894
[Previous SDK PR] #3813

Dynamics, Salesforce and JSONFormat:
[Swagger PR] Azure/azure-rest-api-specs#1850
Azure/azure-rest-api-specs#1903
[Internal item] 97878
[Previous SDK PR] #3811

Support providing Salesforce passwords and security tokens as SecureStrings or as secrets in Azure Key Vault:
[Swagger PR] Azure/azure-rest-api-specs#1917
[Internal item] 97519
[Previous SDK PR] #3816


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

Copy link
Copy Markdown
Member

@markcowl markcowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will need to update the version, also, where are the covering tests for the API changes?


### Feature Additions
* Cancel pipeline run api.
* Add AzureMySql linked service.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will need to update the version for these changes in your csproj file (0.3.0-preview or 0.2.1-preview).

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll be bumping the version in a separate change soon (to 0.2.1-preview), thanks for the reminder

}
}
";
[JsonSample]
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the samples, but I don't see any actual test updates

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these run automatically as part of LinkedService_SerializationTest, Dataset_SerializationTest and Activity_SerializationTest

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see the ClassData attribute on each

@markcowl markcowl merged commit 8d91d91 into Azure:psSdkJson6 Oct 31, 2017
@gadongji gadongji deleted the adfChangesForOctRelease branch November 1, 2017 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants