Skip to content

SDK changes and test samples for AzureMySql connector, including linkedservice, dataset and source.#3813

Closed
gadongji wants to merge 3 commits intoAzure:psSdkJson6from
gadongji:AzureMySql
Closed

SDK changes and test samples for AzureMySql connector, including linkedservice, dataset and source.#3813
gadongji wants to merge 3 commits intoAzure:psSdkJson6from
gadongji:AzureMySql

Conversation

@gadongji
Copy link
Copy Markdown

@gadongji gadongji commented Oct 24, 2017

Description

Related swagger PR: Azure/azure-rest-api-specs#1911
AutoRest is generating a lot of noise and please focus on AzureMySql part.


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

Copy link
Copy Markdown
Contributor

@shahabhijeet shahabhijeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gadongji missing spec PR link
Also missing .txt file that is generated when you use the Spec PR commit to generate the SDK using generate.cmd

@gadongji
Copy link
Copy Markdown
Author

The spec PR was included in the description. and here is the link: Azure/azure-rest-api-specs#1911

@gadongji
Copy link
Copy Markdown
Author

The SDK is generated by AutoRest 2.0.4168

@gadongji
Copy link
Copy Markdown
Author

@shahabhijeet, the changes you requested have been made. Please help review my PRs and merge them asap. Thanks a lot!

@bgold09
Copy link
Copy Markdown
Member

bgold09 commented Oct 27, 2017

approved via internal item 97894

@cormacpayne
Copy link
Copy Markdown
Member

@gadongji Milan's PR was merged earlier this morning: #3812

Please pull in the latest changes from the psSdkJson6 branch into your branch to resolve the merge conflicts and cleanup any potential overlapping changes.

@gadongji
Copy link
Copy Markdown
Author

@cormacpayne I have merged with latest changes and resolved conflicts, please help review and merge again, THX!

@smilenow
Copy link
Copy Markdown
Contributor

Please look at #3824 to prevent double merging. I propose that close this PR after #3824 merged.

@gadongji
Copy link
Copy Markdown
Author

Hi @cormacpayne, we have created a new PR (#3824) which merges three SDK changes from ADMS side to reduce merge conflicts. These three changes are all expected to be included in Nov. release. Please first try to merge the new PR and close this one if succeed. Otherwise, please merge this one on failure. Thanks a lot!

@gadongji gadongji closed this Nov 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants