Skip to content

SDK update for "Support providing Salesforce passwords and security tokens as SecureStrings or as secrets in Azure Key Vault"#3816

Closed
wezou2 wants to merge 7 commits intoAzure:psSdkJson6from
wezou2:psSdkJson6
Closed

SDK update for "Support providing Salesforce passwords and security tokens as SecureStrings or as secrets in Azure Key Vault"#3816
wezou2 wants to merge 7 commits intoAzure:psSdkJson6from
wezou2:psSdkJson6

Conversation

@wezou2
Copy link
Copy Markdown

@wezou2 wezou2 commented Oct 25, 2017

Description


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

@wezou2
Copy link
Copy Markdown
Author

wezou2 commented Oct 25, 2017

This PR has been internally reviewed and the corresponding release item is approved.

Copy link
Copy Markdown
Contributor

@shahabhijeet shahabhijeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add description that describes what is the entire change is all about.
Also add link to your PR

@bgold09
Copy link
Copy Markdown
Member

bgold09 commented Oct 27, 2017

approved via internal item 97519

@bgold09
Copy link
Copy Markdown
Member

bgold09 commented Oct 27, 2017

@wezou2 FYI you have merge conflicts

@smilenow
Copy link
Copy Markdown
Contributor

Please look at #3824 to prevent double merging. I propose that close this PR after #3824 merged.

@wezou2 wezou2 closed this Oct 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants