Skip to content

SDK changes for Dynamics, Salesforce and JSONFormat#3811

Closed
smilenow wants to merge 1 commit intoAzure:psSdkJson6from
smilenow:psSdkJson6
Closed

SDK changes for Dynamics, Salesforce and JSONFormat#3811
smilenow wants to merge 1 commit intoAzure:psSdkJson6from
smilenow:psSdkJson6

Conversation

@smilenow
Copy link
Copy Markdown
Contributor

@smilenow smilenow commented Oct 20, 2017

Description

This PR is aimed to add SDK changes for Dynamics sink, Salesforce dataset, Salesforce sink and update JSONFormat in ADF, and add some new test cases to validate the swagger changes in
src/SDKs/DataFactory/DataFactory.Tests/JsonSamples/DatasetJsonSamples.cs
src/SDKs/DataFactory/DataFactory.Tests/JsonSamples/PipelineJsonSamples.cs

Swagger spec pull request:

  1. Dynamics swagger change: Swagger Changes for Dynamics Sink azure-rest-api-specs#1850 (merged)
  2. Salesforce and JSONFormat swagger change: ADF: Salesforce and JSONFormat azure-rest-api-specs#1903 (merged)

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

@bgold09
Copy link
Copy Markdown
Member

bgold09 commented Oct 23, 2017

do not merge: waiting on formal internal approval

@bgold09
Copy link
Copy Markdown
Member

bgold09 commented Oct 25, 2017

approved via internal item 97878

@smilenow
Copy link
Copy Markdown
Contributor Author

Hi folks, both two swagger changes had been merged, please go ahead this pull request.
cc @bgold09 , @shahabhijeet

@shahabhijeet
Copy link
Copy Markdown
Contributor

@smilenow the PR has conflicts and please regenerate the SDK not that the Spec has been merged and update this PR

@smilenow
Copy link
Copy Markdown
Contributor Author

Please look at #3824 to prevent double merging. I propose that close this PR after #3824 merged.

@smilenow smilenow closed this Nov 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants