Skip to content

Named DiagnosticSettings#1613

Closed
vcanaa wants to merge 10 commits intoAzure:currentfrom
AuxMon:current2
Closed

Named DiagnosticSettings#1613
vcanaa wants to merge 10 commits intoAzure:currentfrom
AuxMon:current2

Conversation

@vcanaa
Copy link
Copy Markdown
Contributor

@vcanaa vcanaa commented Aug 30, 2017 •
edited
Loading

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

This was referenced Aug 30, 2017
Closed
Closed
@gucalder gucalder mentioned this pull request Aug 30, 2017
Closed
10 tasks
@azuresdkciprbot
Copy link
Copy Markdown

azuresdkciprbot commented Aug 30, 2017

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/monitor/resource-manager/readme.md
Before the PR: Warning(s): 23 Error(s): 10
After the PR: Warning(s): 30 Error(s): 12

AutoRest Linter Guidelines | AutoRest Linter Issues

Send feedback and make AutoRest Linter Azure Bot smarter day by day!

Thanks for your co-operation.

@sergey-shandar sergey-shandar self-assigned this Aug 30, 2017
@sergey-shandar sergey-shandar added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 30, 2017
@sergey-shandar
Copy link
Copy Markdown
Contributor

sergey-shandar commented Aug 30, 2017

@ravbhatnagar new API version.

Nicholas King and others added 9 commits August 30, 2017 16:22
@jhendrixMSFT
Update snapshot and deleted app entities for Microsoft.Web (Azure#1566)
ccee585
@sarangan12
Admin Swagger Specs for Commerce, Fabric, and Infrastructure Insights (…
999521d 
…Azure#1592)

* Admin Swagger Specs for Commerce, Fabric, and Infrastructure Insights

* Added Security region to each json

* Fixed Validation Errors

* Fixed validation issues, reorganized folders

* Fixed issues with long running operations and refences.

* Fixed Operation.json references.

* Renamed files and changed capitalization

* Missed renaming of health rp
@JasonYang-MSFT @veronicagg
Storage sku list operation and fix a comment to VirtualNetworkResourc…
971c9dd 
…eId (Azure#1579)

* [Storage] Added support to list skus per subscription.

* [Storage] Fixed a comment on virtual network rule.

* [Storage] Added example for sku list operaion and fixed an issue.

* [Storage] Fixed comments on restriction.
@olydis
Fixed capitalization of CommerceAdmin.json (Azure#1617)
21a810b
@EricSten-MSFT @jianghaolu
APIs for WebJobs, Functions, SiteExtensions and Processes (Azure#1551)
fbefb02 
* Microsoft.Web Adding WebApps documentation
* add deployments/log
* add webjobs, continuouswebjobs, triggeredwebjobs
* add siteextensions
* add processes, instance/processes Diagnostics
* add functions, functions/listsecrets, listsyncfunctiontriggerstatus

* Update with review feedback from pull request Azure#1551

* Update Azure#2 with review feedback from pull request Azure#1551

* Update Azure#3 with review feedback from pull request Azure#1551

* Update Azure#4 with review feedback from pull request Azure#1551

* Update Azure#5 with review feedback from pull request Azure#1551

* Fix merge issues.
@EvgenyAgafonchikov @fearthecowboy
Common specs fixes (Azure#1603)
93a080d
@hrkulkarMsft @anuchandy
[Traffic Manager] Adding new preview api-version for Traffic Manager.…
a5e6b39 
… This adds two new features to Traffic Manager: RealUserMetricsKey, and HeatMap. (Azure#1580)

* Initial commit

* [Traffic Manager] Adding a preview API version for Ignite. This api-version includes a new nested resource: Microsoft.Network/trafficManagerProfiles/heatMaps. This resource will be used to represent a heatmap of a Traffic Manager profile's traffic across a world map based off of the traffic's latency and volume.

[Traffic Manager] Adding new feature to preview API: APP RUM. Also fixing some heatmap specifications.

* Fixing readme.md.
Forcing git to rename HeatMap-Get.json to HeatMap-GET.json
Fixing examples validation and json to match examples.
Adding query parameters to HeatMap. Removing endpoint identifying
properties. Must be accessed through additional GET.
Removing RealUserMetrics API. Needs separate review.
Adding query parameters for HeatMap.
@gucalder @sergey-shandar
[Monitor] Adding proper error response behavior to the Action Groups …
3904406 
…API. Fixing documentation typos in the Activity Log Alerts and Action Groups APIs. (Azure#1622)

* Catching up with missing commits (not moved to the new branch), fFixing issue Azure#1475: incorrect example in LogProfiles API documentation for CreateOrUpdate, fixing incorrect logProfiles example names.

* Removing success response code from example for log profiles delete API call

* Fixing some warnings and one example

* Fixing issues with the examples validation.

* Fixing one example.

* Adding tags and location in the proper place for two examples.

* Fixing name change in the body parameter and the corresponding example file.

* [Monitor] Adding proper error response behavior to the Action Groups API. Fixing documentation typos in the Activity Log Alerts and Action Groups APIs.
@vcanaa
Merge branch 'current2' of github.com:AuxMon/azure-rest-api-specs int…
c0830be 
…o current2
@vcanaa vcanaa closed this Sep 1, 2017
@vcanaa vcanaa reopened this Sep 1, 2017
@vcanaa vcanaa mentioned this pull request Sep 1, 2017
Closed
8 tasks
@azuresdkciprbot
Copy link
Copy Markdown

azuresdkciprbot commented Sep 1, 2017

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/monitor/resource-manager/readme.md
Before the PR: Warning(s): 23 Error(s): 10
After the PR: Warning(s): 30 Error(s): 12

AutoRest Linter Guidelines | AutoRest Linter Issues

Send feedback and make AutoRest Linter Azure Bot smarter day by day!

Thanks for your co-operation.

@sergey-shandar
Copy link
Copy Markdown
Contributor

sergey-shandar commented Sep 1, 2017

@vcanaa +27K new lines. Is it some kind of incorrect merge?

sergey-shandar
sergey-shandar suggested changes Sep 1, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@sergey-shandar sergey-shandar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vcanaa could you submit your changes? It looks like this PR contains some incorrect merges. Let me know if it is not the case.

@ravbhatnagar
Copy link
Copy Markdown
Contributor

ravbhatnagar commented Sep 6, 2017

@sergey-shandar I am not sure if ARM is reviewing Azure Stack APIs. These should be approved and reviewed by folks from Azure Stack team. I will start a thread. THanks!

@sergey-shandar
Copy link
Copy Markdown
Contributor

sergey-shandar commented Sep 6, 2017

@ravbhatnagar @vcanaa the changes contain 119 files including Azure Stack and Azure Resource Management. IMHO, it should be several Pull Requests.

@vcanaa vcanaa closed this Sep 6, 2017
@vcanaa vcanaa deleted the current2 branch September 6, 2017 21:54
@vcanaa vcanaa mentioned this pull request Sep 6, 2017
Merged
8 tasks
mccleanp pushed a commit that referenced this pull request Mar 23, 2022
@raych1
Merge pull request #1613 from Azure/dev/subbart/controller
b01b35d 
Changing controller id to controller key....
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sergey-shandar sergey-shandar sergey-shandar requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@sergey-shandar sergey-shandar

Labels

WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@vcanaa @azuresdkciprbot @sergey-shandar @ravbhatnagar @msftclas @JasonYang-MSFT @EricSten-MSFT @EvgenyAgafonchikov @hrkulkarMsft @gucalder