[data factory] add tumblingWindowTrigger dependsOn and add Folder to pipeline and da…#4741
Merged
dsgouda merged 4 commits intoAzure:psSdkJson6from Sep 7, 2018
haoyingli:psSdkJson6
Merged
[data factory] add tumblingWindowTrigger dependsOn and add Folder to pipeline and da…#4741dsgouda merged 4 commits intoAzure:psSdkJson6from haoyingli:psSdkJson6
dsgouda merged 4 commits intoAzure:psSdkJson6from
haoyingli:psSdkJson6
Conversation
haoyingli
changed the title
hvermis
approved these changes
Sep 5, 2018
Contributor
hvermis
left a comment
hvermis
left a comment
There was a problem hiding this comment.
We will need to update the version of SDK separately
dsgouda
suggested changes
Sep 6, 2018
Contributor
dsgouda
left a comment
dsgouda
left a comment
There was a problem hiding this comment.
Please update PackageReleaseNotes in the csproj
| } | ||
| "; | ||
|
|
||
| [JsonSample] |
Contributor
There was a problem hiding this comment.
nit: please fix indentation
Contributor
Author
There was a problem hiding this comment.
The current Json samples also use these indentation, 8 spaces before [JsonSample], what do you want me to change to?
Contributor
There was a problem hiding this comment.
Move the Json indentation to the right wrt code. Won't block on this.
Contributor
|
@haoyingli Please fix failing tests too |
dsgouda
approved these changes
Sep 6, 2018
dsgouda
suggested changes
Sep 6, 2018
Contributor
dsgouda
left a comment
dsgouda
left a comment
There was a problem hiding this comment.
Please update PackageReleaseNotes
dsgouda
approved these changes
Sep 6, 2018
Contributor
Author
|
When will this PR be merged? I see the status is "Merging is blocked", is there anything blocking it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…taset
This SDK includes 2 swagger changes:
[Datafactory] Add folders to Pipeline and Dataset azure-rest-api-specs#3636
[Data Factory] add tumbling window dependsOn property under stable azure-rest-api-specs#3445
Description
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.