Skip to content

Generate from rest-api-specs and add route api test#2798

Closed
lamchester wants to merge 1 commit intoAzure:AutoRestfrom
lamchester:AutoRest
Closed

Generate from rest-api-specs and add route api test#2798
lamchester wants to merge 1 commit intoAzure:AutoRestfrom
lamchester:AutoRest

Conversation

@lamchester
Copy link
Copy Markdown
Contributor

@lamchester lamchester commented Feb 8, 2017

Regenerate code from after Azure/azure-rest-api-specs#864
And add a test for the three BGP route APIs

Description


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as a link to the swagger spec, used to generate the code.
  • The project.json and AssemblyInfo.cs files have been updated with the new version of the SDK.

@azurecla
Copy link
Copy Markdown

azurecla commented Feb 8, 2017

Hi @lamchester, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!


It looks like you're working at Microsoft (chelam). If you're full-time, we DON'T require a contribution license agreement.



If you are a vendor, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

@cormacpayne
Copy link
Copy Markdown
Member

@lamchester Hey Chester, would you mind resolving the merge conflicts? It looks like you just need to add the license header to the GatewayOperationsTests class

@cormacpayne
Copy link
Copy Markdown
Member

cormacpayne commented Feb 9, 2017

@lamchester also, it looks like you and @dihan0604 are trying to merge in similar changes (#2795). Is there any way you two can consolidate these changes into one PR?

@lamchester
Copy link
Copy Markdown
Contributor Author

@cormacpayne I've updated the branch with newly generated code

@cormacpayne
Copy link
Copy Markdown
Member

Closing this PR since the changes have been pulled into PR #2808

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants