Route Filter Feature Support from Express Route#2795
Route Filter Feature Support from Express Route#2795dihan0604 wants to merge 0 commit intoAzure:AutoRestfrom
Conversation
|
Swagger Spec: |
|
@dihan0604 it looks like the following session record was not found: |
|
@cormacpayne , I debugged this with Abhijeet and we realize we can not have tests in SDK. My feature is enabled in brazilUS (Stage ARM), however, for the current SDK tests, we do not provide this environment. I discussed with Abhijeet and he agreed that I can add tests in PS instead of SDK. I have removed the tests from this PR. Once brazilUS environment is available in SDK, I will add these tests back. |
|
@azuresdkci test this please |
cormacpayne
left a comment
There was a problem hiding this comment.
@dihan0604 a few comments about breaking changes in this pull request. Since this SDK is in preview, it is fine to introduce breaking changes, but you will need to mitigate these changes in PowerShell
Also, you have a large number of commits, so you are going to need to rebase to clean this up
There was a problem hiding this comment.
@dihan0604 changing the order of parameters in the constructor is a breaking change
There was a problem hiding this comment.
@dihan0604 changing the name of this class is a breaking change
|
@dihan0604 it looks like @lamchester just opened a similar PR to this one (#2798). Can we try and consolidate both PR changes into one? |
|
@cormacpayne Comments addressed |
|
@cormacpayne , I chatted with Chester and he agrees to wait my PR get merged and he makes his PR on top of mine. This is due to my swagger changes already merged but not the SDK. |
Description
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
project.jsonandAssemblyInfo.csfiles have been updated with the new version of the SDK.