Skip to content

Added network watcher APIs#923

Merged
amarzavery merged 1 commit intoAzure:masterfrom
irrogozh:networkWatcher
Feb 10, 2017
Merged

Added network watcher APIs#923
amarzavery merged 1 commit intoAzure:masterfrom
irrogozh:networkWatcher

Conversation

@irrogozh
Copy link
Copy Markdown
Member

@irrogozh irrogozh commented Feb 10, 2017

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

  • I have read the contribution guidelines.
  • My spec meets the review criteria:
    • The spec conforms to the Swagger 2.0 specification.
    • Validation errors from the Linter extension for VS Code have all been fixed for this spec. (Note: for large, previously checked in specs, there will likely be many errors shown. Please contact our team so we can set a timeframe for fixing these errors if your PR is not going to address them).
    • The spec follows the patterns described in the Swagger good patterns document unless the service API makes this impossible.

@azurecla
Copy link
Copy Markdown

Hi @irrogozh, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!


It looks like you're working at Microsoft (irrogozh). If you're full-time, we DON'T require a contribution license agreement.



If you are a vendor, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

@amarzavery
Copy link
Copy Markdown
Contributor

@jhendrixMSFT - This PR was reviewed in the private repo. Hence no need to review this again in the public repo.

@amarzavery
Copy link
Copy Markdown
Contributor

amarzavery commented Feb 10, 2017

There have been multiple PRs in the Network RP space:

I know for sure that RouteFilter has some breaking changes to the signature of the "ExpressRouteCircuit" constructor. Hence, it is very important that all the owners of these sub resource types in the NRP space co-ordinate with each other and release one version of an sdk (client) per language (if possible), rather than publishing multiple versions in a very short span.

@DeepakRajendranMsft - Please take a look into this.

/cc @salameer @kirthik @johanste @lmazuel @cormacpayne @markcowl

"./2016-09-01/swagger/usage.json",
"./2016-09-01/swagger/checkDnsAvailability.json",
"./2016-09-01/swagger/virtualNetworkGateway.json",
"./2016-09-01/swagger/networkWatcher.json",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit, spacing.

@amarzavery amarzavery merged commit 7266259 into Azure:master Feb 10, 2017
@AutorestCI
Copy link
Copy Markdown

No modification for NodeJS

@AutorestCI
Copy link
Copy Markdown

@AutorestCI
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants