Skip to content

Added network watcher APIs and tests#2808

Merged
cormacpayne merged 7 commits intoAzure:AutoRestfrom
irrogozh:AutoRest
Feb 15, 2017
Merged

Added network watcher APIs and tests#2808
cormacpayne merged 7 commits intoAzure:AutoRestfrom
irrogozh:AutoRest

Conversation

@irrogozh
Copy link
Copy Markdown
Member

@irrogozh irrogozh commented Feb 10, 2017

Description

Network SDK regenerated from a new swagger spec with added network watcher APIs.
Link to a pull request for swagger: Azure/azure-rest-api-specs#923
AutoRest version: 1.0.0-Nightly20170202
Link on swagger spec: https://github.com/Azure/azure-rest-api-specs-pr/blob/master/arm-network/compositeNetworkClient.json or
https://github.com/irrogozh/azure-rest-api-specs-pr/blob/master/arm-network/compositeNetworkClient.json

I didn't update the link in generate.cmd because I don't know which one I should use, from Azure private repo or from my own public one.


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as a link to the swagger spec, used to generate the code.
  • The project.json and AssemblyInfo.cs files have been updated with the new version of the SDK.

@azuresdkci
Copy link
Copy Markdown
Contributor

Can one of the admins verify this patch?

@azurecla
Copy link
Copy Markdown

Hi @irrogozh, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!


It looks like you're working at Microsoft (irrogozh). If you're full-time, we DON'T require a contribution license agreement.



If you are a vendor, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

Copy link
Copy Markdown
Contributor

@twitchax twitchax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - @irrogozh, can you fill out the PR checklist, please? :)

@cormacpayne
Copy link
Copy Markdown
Member

@azuresdkci add to whitelist

Copy link
Copy Markdown
Member

@cormacpayne cormacpayne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@irrogozh Hey Irina, in addition to the comment I left in the code

  • you will need to update the version in project.json to whatever the version should be for release

  • you will need to update the version in AssemblyInfo.cs with the same version

Project("{8BB2217D-0F2D-49D1-97BC-3654ED321F3B}") = "Microsoft.Azure.Management.Network", "Microsoft.Azure.Management.Network\Microsoft.Azure.Management.Network.xproj", "{4F22B186-DEB4-4B95-BA58-0187F0E32993}"
EndProject
Project("{8BB2217D-0F2D-49D1-97BC-3654ED321F3B}") = "Microsoft.Azure.Management.Storage", "..\Storage\Microsoft.Azure.Management.Storage\Microsoft.Azure.Management.Storage.xproj", "{A9B44E1B-C26F-44AB-B13F-F22742371125}"
EndProject
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@irrogozh why were Compute and Storage added to this file? It looks like you are trying to use them for tests, but you already have a reference to their published packages in the Network.Tests/project.json, so you don't need to reference the path to their code in this file.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@cormacpayne cormacpayne self-assigned this Feb 14, 2017
@DeepakRajendranMsft
Copy link
Copy Markdown
Contributor

@markcowl @cormacpayne can this be merged now please.

Thanks,
deepak.

@cormacpayne cormacpayne merged commit 50f9cf9 into Azure:AutoRest Feb 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants