Added network watcher APIs and tests#2808
Added network watcher APIs and tests#2808cormacpayne merged 7 commits intoAzure:AutoRestfrom irrogozh:AutoRest
Conversation
|
Can one of the admins verify this patch? |
|
Hi @irrogozh, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!
TTYL, AZPRBOT; |
|
@azuresdkci add to whitelist |
cormacpayne
left a comment
There was a problem hiding this comment.
@irrogozh Hey Irina, in addition to the comment I left in the code
-
you will need to update the version in project.json to whatever the version should be for release
-
you will need to update the version in AssemblyInfo.cs with the same version
| Project("{8BB2217D-0F2D-49D1-97BC-3654ED321F3B}") = "Microsoft.Azure.Management.Network", "Microsoft.Azure.Management.Network\Microsoft.Azure.Management.Network.xproj", "{4F22B186-DEB4-4B95-BA58-0187F0E32993}" | ||
| EndProject | ||
| Project("{8BB2217D-0F2D-49D1-97BC-3654ED321F3B}") = "Microsoft.Azure.Management.Storage", "..\Storage\Microsoft.Azure.Management.Storage\Microsoft.Azure.Management.Storage.xproj", "{A9B44E1B-C26F-44AB-B13F-F22742371125}" | ||
| EndProject |
There was a problem hiding this comment.
@irrogozh why were Compute and Storage added to this file? It looks like you are trying to use them for tests, but you already have a reference to their published packages in the Network.Tests/project.json, so you don't need to reference the path to their code in this file.
|
@markcowl @cormacpayne can this be merged now please. Thanks, |
Description
Network SDK regenerated from a new swagger spec with added network watcher APIs.
Link to a pull request for swagger: Azure/azure-rest-api-specs#923
AutoRest version: 1.0.0-Nightly20170202
Link on swagger spec: https://github.com/Azure/azure-rest-api-specs-pr/blob/master/arm-network/compositeNetworkClient.json or
https://github.com/irrogozh/azure-rest-api-specs-pr/blob/master/arm-network/compositeNetworkClient.json
I didn't update the link in generate.cmd because I don't know which one I should use, from Azure private repo or from my own public one.
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
project.jsonandAssemblyInfo.csfiles have been updated with the new version of the SDK.