Merged
Conversation
amnguye
approved these changes
Jul 1, 2020
| } | ||
| catch (RequestFailedException) | ||
| { | ||
| } |
Member
There was a problem hiding this comment.
If GetProperties fails, is it okay to catch it and pass the test?
Member
Author
There was a problem hiding this comment.
We need to look into this one, I don't remember what I was doing here.
| } | ||
|
|
||
| /// <summary> | ||
| /// |
Member
There was a problem hiding this comment.
Oh I meant in the summary add "Constructor" cause it's blank
Comment on lines
+175
to
+177
| // If the dictionary contains a key with policy id, we are not required to do any parsing since | ||
| // the policy id should already be stored in the ObjectReplicationDestinationPolicyId. | ||
| if (OrIds.First().Key == "policy-id") |
Member
There was a problem hiding this comment.
If we get the Object Replication properties of a destination blob, then it will be the only entry in the dictionary (with a key value of "policy-id")
Member
Author
|
/azp run net - storage - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run net - storage - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run net - storage - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run net - storage - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run net - storage - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
Test results: The main issues
|
prmathur-microsoft
pushed a commit
that referenced
this pull request
Jul 8, 2020
This was referenced Jul 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.