Feature/storage/stg73comments#13346
Merged
seanmcc-msft merged 24 commits intoAzure:masterfrom Jul 23, 2020
Merged
Conversation
ghost
added
the
Member
Author
seanmcc-msft
requested review from
amishra-dev,
amnguye,
kasobol-msft and
tg-msft
as code owners
jaschrep-msft
approved these changes
Jul 23, 2020
Member
jaschrep-msft
left a comment
jaschrep-msft
left a comment
There was a problem hiding this comment.
Good changes. Couple names to update with our patterns.
| @@ -39,10 +40,11 @@ public ChangeFeedFactory( | |||
| } | |||
|
|
|||
| public async Task<ChangeFeed> BuildChangeFeed( | |||
Member
There was a problem hiding this comment.
Looks public in this, but is on an internal class.
Member
Author
There was a problem hiding this comment.
I think we should be fine - Public things on an internal class are still internal.
| @@ -170,15 +178,17 @@ private static void ValidateCursor( | |||
| } | |||
|
|
|||
| internal async Task<Queue<string>> GetYearPaths( | |||
Member
Author
There was a problem hiding this comment.
Fixed in next iteration.
kasobol-msft
approved these changes
Jul 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #13187
STG 73 PR - #13105