Merged
Conversation
ljian3377
requested review from
HarshaNalluru,
XiaoningLiu,
bterlson,
jeremymeng,
jiacfan,
vinjiang and
xirzec
as code owners
ljian3377
added
the
APIChange
Member
Author
|
/azp run js - storage-blob - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run js - storage-blob - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ljian3377
commented
Jul 10, 2020
Member
Author
|
/azp run js - storage-blob - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
bterlson
approved these changes
Jul 13, 2020
Member
bterlson
left a comment
bterlson
left a comment
There was a problem hiding this comment.
Approved, though there's a slight simplification we could make if it works...
Member
Author
|
/azp run js - storage-blob - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run js - storage-blob - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
Will return list to align with other languages. |
jiacfan
reviewed
Aug 25, 2020
jiacfan
reviewed
Aug 25, 2020
jiacfan
approved these changes
Aug 25, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skipping live tests for ors as it needs to set up two accounts and object replicate rules, which requires ARM tools.
.NET PRs:
root PR: Azure/azure-sdk-for-net#13105
download & get properties: Azure/azure-sdk-for-net#11909
adjustment:
Azure/azure-sdk-for-net#12740
Azure/azure-sdk-for-net#12786
List blob: Azure/azure-sdk-for-net#13055