Added Seal Append Blob#11262
Conversation
seanmcc-msft
requested review from
JoshLove-msft,
KrzysztofCwalina,
amnguye,
kasobol-msft,
pakrym and
tg-msft
as code owners
| { | ||
| try | ||
| { | ||
| Response<AppendBlobSealInternal> response = await BlobRestClient.AppendBlob.SealAsync( |
There was a problem hiding this comment.
I'm not seeing AppendBlobSealInternal defined in this PR. Are there any additional interesting properties outside of what's provided by BlobInfo on it?
There was a problem hiding this comment.
Nope, it's just ETag, LastModified, and a boolean IsSealed.
|
The spec was out of date, we don't need to add x-ms-blob-seal to |
|
@tg-msft, I had to add a new parameter to |
| StandardZrs = 3, | ||
| PremiumLrs = 4, | ||
| } | ||
| public partial class StartCopyFromUriOptions |
There was a problem hiding this comment.
Should this just be CopyFromUriOptions? The Start prefix is only to signify that it's an LRO and not part of the operation name. I'll ping @KrzysztofCwalina to see if he has a preference and get back to you ASAP.
There was a problem hiding this comment.
I'd vote for CopyBlobFromUriOptions, it's less generic.
There was a problem hiding this comment.
Krzysztof is in favor of shorter/simpler names when we can make sure we're not going to end up with conflicts down the road. I'm not worried about adding a CopyFromUriAsync that would take different parameters so that's fine.
I think you bring up a really good point that we may possibly end up adding other copy operations in the future. How about BlobCopyFromUriOptions since other copy operations would probably be operating on blobs and the pattern we've been going with is [Operation]Options when possible or [FooClient - Client][Operation]Options? This would leave us room for (BlobContainer/Service/????)CopyFromUriOptions if ever needed.
Does that sound reasonable? Ping me if you want to chat more to hopefully unblock this faster.
There was a problem hiding this comment.
I think BlobCopyFromUriOptions sounds good.
| public Azure.Storage.Blobs.Models.BlobRequestConditions DestinationConditions { get { throw null; } set { } } | ||
| public System.Collections.Generic.IDictionary<string, string> Metadata { get { throw null; } set { } } | ||
| public Azure.Storage.Blobs.Models.RehydratePriority? RehydratePriority { get { throw null; } set { } } | ||
| public bool? SealBlob { get { throw null; } set { } } |
There was a problem hiding this comment.
Should we make this IsSealed to match the other uses of the property?
There was a problem hiding this comment.
Sure, that seems reasonable.
|
@tg-msft, let me know the resolution for |
3 participants
No description provided.