[Azure App Configuration] - Normalize the query parameters in request url #35962
+345
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhiyuanliang-ms
requested review from
minhanh-phan and
zhenlan
as code owners
github-actions
bot
added
the
App Configuration
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds query parameter normalization to the Azure App Configuration client to support Azure Front Door as a CDN. The implementation ensures all query parameters are converted to lowercase and sorted alphabetically for consistent, canonical request URLs.
Key changes:
- New pipeline policy for query parameter normalization
- Comprehensive test coverage for the normalization behavior
- File naming correction for consistency
Reviewed Changes
Copilot reviewed 6 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
src/internal/queryParamPolicy.ts |
New pipeline policy that normalizes query parameters to lowercase and sorts them alphabetically |
src/appConfigurationClient.ts |
Integrates the query param normalization policy into the client pipeline and fixes import path |
test/public/queryParam.spec.ts |
End-to-end tests verifying query parameter ordering in real client operations |
test/internal/queryParamPolicy.spec.ts |
Unit tests for the query parameter normalization policy |
test/internal/node/http.spec.ts |
Updates import path to match corrected filename casing |
CHANGELOG.md |
Documents the new feature and minor formatting cleanup |
sdk/appconfiguration/app-configuration/test/public/queryParam.spec.ts
Outdated
Show resolved
Hide resolved
sdk/appconfiguration/app-configuration/test/internal/queryParamPolicy.spec.ts
Outdated
Show resolved
Hide resolved
sdk/appconfiguration/app-configuration/src/internal/queryParamPolicy.ts
Outdated
Show resolved
Hide resolved
Member
Author
|
I didn't update the test recording. Waiting for PR #35952 to be merged, which fixes the listLabels test. |
xirzec
reviewed
Sep 17, 2025
sdk/appconfiguration/app-configuration/src/internal/queryParamPolicy.ts
Outdated
Show resolved
Hide resolved
xirzec
reviewed
Sep 17, 2025
sdk/appconfiguration/app-configuration/src/internal/queryParamPolicy.ts
Outdated
Show resolved
Hide resolved
…or-js into zhiyuanliang/sort-query-param
…or-js into zhiyuanliang/sort-query-param
avanigupta
reviewed
Sep 24, 2025
sdk/appconfiguration/app-configuration/src/internal/queryParamPolicy.ts
Outdated
Show resolved
Hide resolved
sdk/appconfiguration/app-configuration/src/internal/queryParamPolicy.ts
Outdated
Show resolved
Hide resolved
zhiyuanliang-ms
requested review from
RichardChen820,
jimmyca15 and
juniwang
as code owners
xirzec
reviewed
Oct 17, 2025
Member
xirzec
left a comment
xirzec
left a comment
There was a problem hiding this comment.
A suggestion on how to implement the correct behavior without encoding side-effects
sdk/appconfiguration/app-configuration/src/internal/queryParamPolicy.ts
Outdated
Show resolved
Hide resolved
sdk/appconfiguration/app-configuration/src/internal/queryParamPolicy.ts
Outdated
Show resolved
Hide resolved
sdk/appconfiguration/app-configuration/src/internal/queryParamPolicy.ts
Outdated
Show resolved
Hide resolved
jimmyca15
reviewed
Oct 21, 2025
…or-js into zhiyuanliang/sort-query-param
jimmyca15
reviewed
Oct 24, 2025
sdk/appconfiguration/app-configuration/src/internal/queryParamPolicy.ts
Outdated
Show resolved
Hide resolved
jimmyca15
reviewed
Oct 24, 2025
jimmyca15
approved these changes
Oct 24, 2025
jimmyca15
approved these changes
Oct 24, 2025
jimmyca15
reviewed
Oct 24, 2025
3 tasks
avanigupta
reviewed
Oct 27, 2025
6 tasks
zhiyuanliang-ms
added a commit
that referenced
this pull request
Nov 2, 2025
### Packages impacted by this PR @azure/app-configuration ### Issues associated with this PR See [comment](#35962 (comment)) ### Describe the problem that is addressed by this PR ### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen? ### Are there test cases added in this PR? _(If not, why?)_ ### Provide a list of related PRs _(if any)_ ### Command used to generate this PR:**_(Applicable only to SDK release request PRs)_ ### Checklists - [ ] Added impacted package name to the issue description - [ ] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_ - [ ] Added a changelog (if necessary) --------- Co-authored-by: Minh-Anh Phan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
@azure/app-configuration
Issues associated with this PR
Describe the problem that is addressed by this PR
Adds a new pipeline to update the query params to make sure they are all lowercase and in alphabetical order. This is required for support of Azure Front Door as a CDN.
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Are there test cases added in this PR? (If not, why?)
Yes
Provide a list of related PRs (if any)
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists