Skip to content

Conversation

@zhiyuanliang-ms
Copy link
Member

Why this PR?

Adds a new pipeline to update the query params to make sure they are all lowercase and in alphabetical order. This is required for support of Azure Front Door as a CDN.

Copilot AI review requested due to automatic review settings October 10, 2025 02:45
@github-actions github-actions bot added the App Configuration Azure.ApplicationModel.Configuration label Oct 10, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new query parameter normalization pipeline policy to the Azure App Configuration SDK. The policy ensures query parameters are lowercase and sorted alphabetically to support Azure Front Door as a CDN.

  • Implements a new QueryParamPolicy that transforms query parameters to lowercase and sorts them alphabetically
  • Adds comprehensive test coverage for various query parameter scenarios including duplicates and encoded values
  • Removes the unused ApiVersionPolicy class as part of cleanup

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
QueryParamPolicy.cs New pipeline policy that normalizes query parameters by converting to lowercase and sorting alphabetically
QueryParamPolicyTests.cs Comprehensive test suite covering lowercase conversion, sorting, duplicate handling, and value preservation
ConfigurationClient.cs Integration of the new QueryParamPolicy into the HTTP pipeline
ApiVersionPolicy.cs Removal of unused ApiVersionPolicy class
assets.json Version tag update for the changes

@jimmyca15
Copy link
Member

jimmyca15 commented Oct 30, 2025

I suggest putting a summary on the class that describes what it is for.

@zhiyuanliang-ms zhiyuanliang-ms merged commit 6136233 into Azure:main Nov 3, 2025
17 checks passed
nick863 pushed a commit that referenced this pull request Nov 5, 2025
* add query param policy

* update

* update

* update

* update

* add test

* catch UriFormatException

* update

* remove try-catch

* add summary comment for pipeline policy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

App Configuration Azure.ApplicationModel.Configuration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants