Skip to content

Conversation

@zhiyuanliang-ms
Copy link
Member

@zhiyuanliang-ms zhiyuanliang-ms commented Sep 16, 2025

Packages impacted by this PR

@azure/app-configuration

Issues associated with this PR

#35887

Describe the problem that is addressed by this PR

parallel CI jobs (or other tests) that introduce an unlabeled setting can cause an additional { name: null } label to appear between successive enumerations in toSortedLabelsArray, leading to a mismatch.

What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?

Are there test cases added in this PR? (If not, why?)

Yes.

Provide a list of related PRs (if any)

Command used to generate this PR:**(Applicable only to SDK release request PRs)

Checklists

  • Added impacted package name to the issue description
  • Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
  • Added a changelog (if necessary)

Copilot AI review requested due to automatic review settings September 16, 2025 09:04
@github-actions github-actions bot added the App Configuration Azure.ApplicationModel.Configuration label Sep 16, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses a race condition in App Configuration tests where parallel CI jobs could introduce unlabeled settings that interfere with the listLabels test assertions. The fix adds nameFilter parameters to ensure tests only retrieve labels created specifically for each test case.

  • Adds nameFilter: uniqueLabel to listLabels() calls in two test cases
  • Includes detailed comments explaining the deterministic behavior requirement

@zhiyuanliang-ms zhiyuanliang-ms changed the title [App Configuration] - Make listl abel test deterministic [App Configuration] - Make list label test deterministic Sep 16, 2025
@zhiyuanliang-ms zhiyuanliang-ms merged commit 2cad48c into Azure:main Sep 18, 2025
13 checks passed
@zhiyuanliang-ms zhiyuanliang-ms deleted the zhiyuanliang/update-appconfig-test branch October 2, 2025 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

App Configuration Azure.ApplicationModel.Configuration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants