App Config - Query Param Ordering #46665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

mrm9084 merged 29 commits into Azure:main from mrm9084:QueryParamaterPipeline

Nov 3, 2025

Member

mrm9084 commented Sep 11, 2025

Description

Adds a new pipeline to update the query params to make sure they are all lowercase and in alphabetical order. This is required for support of Azure Front Door as a CDN.

All SDK Contribution checklist:

The pull request does not introduce [breaking changes]
CHANGELOG is updated for new features, bug fixes or other significant changes.
I have read the contribution guidelines.

General Guidelines and Best Practices

Title of the pull request is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

Pull request includes test coverage for the included changes.

mrm9084 added 2 commits

September 11, 2025 15:54


          SortsQueryParams

30c39e1


          Update CHANGELOG.md

2a863f2

mrm9084 requested review from avanigupta and Copilot

September 11, 2025 23:01

mrm9084 requested review from a team and alzimmermsft as code owners

September 11, 2025 23:01

github-actions bot added the App Configuration label

Copilot AI reviewed

View reviewed changes

Contributor

Copilot AI left a comment

Pull Request Overview

This PR adds a new pipeline policy to normalize query parameters for Azure App Configuration requests to support Azure Front Door as a CDN. The policy ensures query parameter keys are converted to lowercase and sorted alphabetically.

Key Changes:

Added a new QueryParamPolicy that normalizes query parameters by converting keys to lowercase and sorting them alphabetically
Integrated the policy into the HTTP pipeline in ConfigurationClientBuilder
Added comprehensive test coverage for various query parameter scenarios

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File	Description
QueryParamPolicy.java	New pipeline policy implementation that normalizes query parameters
QueryParamPolicyTest.java	Comprehensive test suite covering various query parameter scenarios
ConfigurationClientBuilder.java	Integration of the new policy into the HTTP pipeline
CHANGELOG.md	Documentation of the new feature

...iguration/src/main/java/com/azure/data/appconfiguration/implementation/QueryParamPolicy.java Show resolved Hide resolved

...iguration/src/main/java/com/azure/data/appconfiguration/implementation/QueryParamPolicy.java Outdated Show resolved Hide resolved

...iguration/src/main/java/com/azure/data/appconfiguration/implementation/QueryParamPolicy.java Show resolved Hide resolved


          Update QueryParamPolicy.java

c6e085f

avanigupta reviewed

View reviewed changes

...iguration/src/main/java/com/azure/data/appconfiguration/implementation/QueryParamPolicy.java Outdated Show resolved Hide resolved

avanigupta reviewed

View reviewed changes

...iguration/src/main/java/com/azure/data/appconfiguration/implementation/QueryParamPolicy.java Outdated Show resolved Hide resolved

mrm9084 added 3 commits

September 12, 2025 10:32


          Fixing tags

1c451cf


          Style fixes

cd062ee


          Update QueryParamPolicyTest.java

edbecab

avanigupta reviewed

View reviewed changes

...ation/src/test/java/com/azure/data/appconfiguration/implementation/QueryParamPolicyTest.java Show resolved Hide resolved

avanigupta reviewed

View reviewed changes

...ation/src/test/java/com/azure/data/appconfiguration/implementation/QueryParamPolicyTest.java Outdated Show resolved Hide resolved


          Update QueryParamPolicyTest.java

858ae3c

avanigupta reviewed

View reviewed changes

...iguration/src/main/java/com/azure/data/appconfiguration/implementation/QueryParamPolicy.java Outdated Show resolved Hide resolved


          Update QueryParamPolicyTest.java

387731f

zhiyuanliang-ms reviewed

View reviewed changes

...ation/src/test/java/com/azure/data/appconfiguration/implementation/QueryParamPolicyTest.java Show resolved Hide resolved

zhiyuanliang-ms reviewed

View reviewed changes

...iguration/src/main/java/com/azure/data/appconfiguration/implementation/QueryParamPolicy.java Outdated Show resolved Hide resolved

zhiyuanliang-ms mentioned this pull request

add support for connecting to Azure Front Door with Azure App Configuration store as an origin Azure/AppConfiguration-DotnetProvider#601

Closed

mrm9084 added 3 commits

October 9, 2025 09:10


          Update assets.json

d73ca61


          review items

0efdeb4


          Merge branch 'main' into QueryParamaterPipeline

e0d02bb

mrm9084 requested a review from Copilot

October 9, 2025 19:18

Copilot AI reviewed

View reviewed changes

Contributor

Copilot AI left a comment

Pull Request Overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

...ration/src/test/java/com/azure/data/appconfiguration/implementation/SyncTokenPolicyTest.java Show resolved Hide resolved

...iguration/src/main/java/com/azure/data/appconfiguration/implementation/QueryParamPolicy.java Outdated Show resolved Hide resolved

mrm9084 added 2 commits

October 9, 2025 12:42


          Update QueryParamPolicy.java

404b483


          Merge branch 'QueryParamaterPipeline' of https://github.com/mrm9084/a…

7193a4a

…zure-sdk-for-java into QueryParamaterPipeline

avanigupta reviewed

View reviewed changes

...iguration/src/main/java/com/azure/data/appconfiguration/implementation/QueryParamPolicy.java Outdated Show resolved Hide resolved

...iguration/src/main/java/com/azure/data/appconfiguration/implementation/QueryParamPolicy.java Outdated Show resolved Hide resolved

...iguration/src/main/java/com/azure/data/appconfiguration/implementation/QueryParamPolicy.java Outdated Show resolved Hide resolved

jairmyree requested review from KarishmaGhiya, KevinBlasko, ToddKingMSFT, gulopesd and scottaddie

October 22, 2025 01:14


          updating test files to use TME subscription

dd05f82

alzimmermsft approved these changes

View reviewed changes


          Updating assets.json for azure-monitor-query-metrics

b1570ec

jairmyree requested a review from a team as a code owner

October 27, 2025 18:23

jairmyree requested review from leelabysani, qing-zhao and rakeshrana44

October 27, 2025 18:23

Contributor

github-actions bot commented Oct 27, 2025 •

edited

Loading

API Change Check

APIView identified API level changes in this PR and created the following API reviews

com.azure:azure-data-appconfiguration

jairmyree added 4 commits

October 27, 2025 12:53


          Changing monitor app-config dependency to current to pull new changes

5d43d7b


          Changing monitor app-config dependencies

3255ca4


          updating assets.json

110b832


          Merge branch 'main' into QueryParamaterPipeline

avanigupta reviewed

View reviewed changes

...iguration/src/main/java/com/azure/data/appconfiguration/implementation/QueryParamPolicy.java Show resolved Hide resolved

jairmyree added 4 commits

October 30, 2025 16:24


          Changing monitor dependency to unreleased app config

18dd52e


          Merge branch 'main' into QueryParamaterPipeline

f1e8dd6


          Updating assets.json files

6a1e309


          updated pom and assets.json

6e20621

alzimmermsft approved these changes

View reviewed changes

Member

rossgrambo commented Oct 31, 2025

What are all the azure monitor changes here? Do they relate to app config?

Member Author

mrm9084 commented Oct 31, 2025

What are all the azure monitor changes here? Do they relate to app config?

Azure Monitor uses us to test there service. We broke there recordings.


          Update QueryParamPolicyTest.java

94139bc

avanigupta approved these changes

View reviewed changes


          Merge branch 'main' into QueryParamaterPipeline

e393d1f

mrm9084 merged commit 935d4bd into Azure:main

18 checks passed

mrm9084 deleted the QueryParamaterPipeline branch

November 3, 2025 20:54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

zhiyuanliang-ms zhiyuanliang-ms left review comments

Copilot code review Copilot Copilot left review comments

avanigupta avanigupta approved these changes

alzimmermsft alzimmermsft approved these changes

srnagar Awaiting requested review from srnagar srnagar is a code owner

jairmyree Awaiting requested review from jairmyree jairmyree is a code owner

joshfree Awaiting requested review from joshfree joshfree is a code owner automatically assigned from Azure/azure-sdk-write-monitor-data-plane

pvaneck Awaiting requested review from pvaneck pvaneck is a code owner automatically assigned from Azure/azure-sdk-write-monitor-data-plane

KevinBlasko Awaiting requested review from KevinBlasko KevinBlasko is a code owner automatically assigned from Azure/azure-sdk-write-monitor-data-plane

KarishmaGhiya Awaiting requested review from KarishmaGhiya KarishmaGhiya is a code owner automatically assigned from Azure/azure-sdk-write-monitor-data-plane

scottaddie Awaiting requested review from scottaddie scottaddie is a code owner automatically assigned from Azure/azure-sdk-write-monitor-data-plane

ToddKingMSFT Awaiting requested review from ToddKingMSFT ToddKingMSFT is a code owner automatically assigned from Azure/azure-sdk-write-monitor-data-plane

gulopesd Awaiting requested review from gulopesd gulopesd is a code owner automatically assigned from Azure/azure-sdk-write-monitor-data-plane

qing-zhao Awaiting requested review from qing-zhao qing-zhao is a code owner automatically assigned from Azure/azure-sdk-write-monitor-query-metrics

leelabysani Awaiting requested review from leelabysani leelabysani is a code owner automatically assigned from Azure/azure-sdk-write-monitor-query-metrics

rakeshrana44 Awaiting requested review from rakeshrana44 rakeshrana44 is a code owner automatically assigned from Azure/azure-sdk-write-monitor-query-metrics

Labels

App Configuration