Skip to content

Issues/5530 use consistent naming #5698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
chrischild wants to merge 21 commits into from
Closed

Issues/5530 use consistent naming #5698

chrischild wants to merge 21 commits into from

Conversation

@chrischild
Copy link
Contributor

@chrischild chrischild commented Oct 4, 2019 •
edited by conniey
Loading

Created a new Checkstyle to look for specific words that should follow normal camelcasing standards.

Since it seems like there could be a growing list of words I added the ability to pass in a set of words that should be checked against.

Currently I checked in the checkstyle.xml that has an example of usage.

Since I did not have a set of concrete words I have not gone and changed any of the outstanding naming issues that were not fixed in #5544. If provided with a full list I can do that as well.

Fixes #5530

@msftclas
Copy link

msftclas commented Oct 4, 2019 •
edited
Loading

CLA assistant check
All CLA requirements met.

@azuresdkci
Copy link
Contributor

azuresdkci commented Oct 4, 2019

Can one of the admins verify this patch?

@chrischild
Copy link
Contributor Author

chrischild commented Oct 5, 2019

Removed the error message for missing disallowedWords property. It was a hack and didn't feel like it was a good solution. Changed to now have 2 default values to search for, URL and HTTP. This can still be overwritten by setting the disallowedWords property.

Chris and others added 15 commits October 4, 2019 21:57
New Checkstyle for disallowed words. (Azure#5530)
19a4f7e
New Checkstyle for disallowed words. (Azure#5530)
3ae6a99 
New Checkstyle for disallowed words. (Azure#5530)

New Checkstyle for disallowed words. (Azure#5530)

New Checkstyle for disallowed words. (Azure#5530)
@sima-zhu
Initial change for changeLog and readme (Azure#5658)
6c98480
@conniey
Adds support for proxies in Event Hubs (Azure#5621)
30ac105 
* Add WebSocketsProxyConnectionHandler.

* Update ReactorHandlerProvider to connect proxy.

* Add Objects.requiresNotNull check.

* Integration web proxy handler in ReactorConnection.

* Fix API for MockReactorHandlerProvider.

* Adding tests for WebSocketsProxyConnectionHandler.

* Use logger.throw

* Adding tests for ReactorHandlerProvider.

* Adding documentation to WebSocketsProxyConnectionHandler. Using SystemDefaults when a proxy should be used.

* Asserting UserAgent string is in connection properties.

* Adding simple proxy for integration tests.

* Update IntegrationTestBase to getProxyConfiguration from configuration.

* Add ProxyIntegrationTest.

* Add ProxyReceiveTest.

* Handling PROTON_IO errors.

* Add integration tests for proxy configuration.

* Cleaning up simple proxy.

* Ignore tests until simple proxy is fixed.
@samvaity
Fixes possible null pointer deference spotbugs issue on Key Vault cli…
33bedb2 
…ents (Azure#5678)
@sima-zhu
Move the datalake error models to implementation model (Azure#5695)
a72edc8
@sima-zhu
Readme update for sasToken API in builder (Azure#5697)
ae62758
@alzimmermsft
Remove SAS Generation Methods from Clients (Azure#5617)
e0a4a3e 
* Remove SAS generation methods from Azure Blob clients

* Add some resource type logic to BlobServiceSASSignatureValues

* Fix failing test

* Removed SAS token methods in Queue clients

* Fixing some more tests

* Fix Javadoc links

* Fixing linting issues, prototyping BlobSasConstructor

* Minor refactoring in new class

* Re-record failing tests

* Fix checkstyle issues

* Fix accidentally method name change

* Fix javadoc issue

* Cleanup checkstyle issues

* Make SAS generation classes public API

* Fixing checkstyle issues
@conniey
azure-core JavaDocs and code snippet clean-up (Azure#5653)
5cc9153 
* Updating comments in package-info.java.

* Update documentation in Tracer and TracerProxy.

* Add doc updates to Poller.

* Making code snippets more reactor-ish.

* Fix naming.

* Fix typos.

* Move ClientLogger java doc samples to correct location.

* Update documentation in ClientLogger.

* Fix codesnippet references.

* Update package-info.java

* Update parameter docs.
@sima-zhu
Storage InputStream and OutputStream (Azure#5455)
ce3e131
@srnagar
Renaming classes and methods as per naming guidelines (Azure#5691)
d7b3d91 
* Renaming classes and methods as per naming guidelines
@srnagar
Update README and CHANGELOG for Event Hubs (Azure#5700)
950bc61 
* Update README and CHANGELOG for Event Hubs

* Add async clients to changelog
@alzimmermsft
Add remove to HttpHeaders (Azure#5704)
baa2dab 
* Add remove to HttpHeaders

* Use ConcurrentHashMap
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-java …
9a53f37 
…into issues/5530-use-consistent-naming
Merge branch 'issues/5530-use-consistent-naming' of https://github.co…
518f8f9 
…m/chrischild/azure-sdk-for-java into issues/5530-use-consistent-naming
@chrischild chrischild force-pushed the issues/5530-use-consistent-naming branch from 518f8f9 to 19a4f7e Compare October 5, 2019 07:04
@chrischild
Copy link
Contributor Author

chrischild commented Oct 5, 2019

Tried to squash some commits and that didn't seem to work so reset to previous good commit.

JonathanGiles
JonathanGiles reviewed Oct 6, 2019
View reviewed changes
Copy link
Member

@JonathanGiles JonathanGiles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very promising. Left some feedback for your consideration. Thanks!

@chrischild
Copy link
Contributor Author

chrischild commented Oct 15, 2019

Just wanted to check in.

@chrischild
Copy link
Contributor Author

chrischild commented Oct 22, 2019 •
edited
Loading

Just popping in again and wanted to point out that I have created a new branch for all the files that were changed. I found that there were quite a few, over 100, and I think it would pollute this PR to check it into the same branch. The new branch commit is here

conniey
conniey requested changes Oct 24, 2019
View reviewed changes
Copy link
Member

@conniey conniey left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments. It looks great! Thanks so much. :)

JonathanGiles
JonathanGiles approved these changes Oct 24, 2019
View reviewed changes
Copy link
Member

@JonathanGiles JonathanGiles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! Connie has a few pieces of minor feedback, and I'm just wanting to see if any issues arise when you turn this on. We are close to getting this merged!

@chrischild chrischild mentioned this pull request Oct 24, 2019
Closed
@chrischild
Copy link
Contributor Author

chrischild commented Oct 24, 2019

How do you feel about the naming I used? I also think BlacklistedWords might be better but either works.

@conniey
Copy link
Member

conniey commented Oct 24, 2019

@chrischild I like blacklist, it's concise. I won't lose sleep if you decide not to change it though.

@chrischild chrischild closed this Oct 25, 2019
@chrischild chrischild deleted the issues/5530-use-consistent-naming branch October 25, 2019 23:09
@chrischild
Copy link
Contributor Author

chrischild commented Oct 25, 2019

Sorry I'm just fixing an issue with Git I found.

@chrischild chrischild mentioned this pull request Oct 25, 2019
Merged
@chrischild
Copy link
Contributor Author

chrischild commented Oct 25, 2019

GitHub does not allow you to re-open a branch if it has been recreated apparently so I had to create a new PR here.

Apologies but I was committing some info that I didn't want to be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@conniey conniey conniey requested changes

@JonathanGiles JonathanGiles JonathanGiles approved these changes

@mssfang mssfang Awaiting requested review from mssfang

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Use consistent naming for methods/parameters.

9 participants

@chrischild @msftclas @azuresdkci @conniey @JonathanGiles @sima-zhu @samvaity @alzimmermsft @srnagar