Adds support for proxies in Event Hubs #5621
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conniey
added
Event Hubs
Client
conniey
requested review from
alzimmermsft,
hemanttanwar,
jianghaolu and
mssfang
as code owners
conniey
commented
Oct 1, 2019
...c/main/java/com/azure/core/amqp/implementation/handler/WebSocketsProxyConnectionHandler.java
Outdated
Show resolved
Hide resolved
JonathanGiles
approved these changes
Oct 1, 2019
alzimmermsft
approved these changes
Oct 3, 2019
srnagar
reviewed
Oct 3, 2019
sdk/core/azure-core-amqp/src/main/java/com/azure/core/amqp/exception/ErrorCondition.java
Show resolved
Hide resolved
...c/main/java/com/azure/core/amqp/implementation/handler/WebSocketsProxyConnectionHandler.java
Show resolved
Hide resolved
...c/main/java/com/azure/core/amqp/implementation/handler/WebSocketsProxyConnectionHandler.java
Show resolved
Hide resolved
...c/main/java/com/azure/core/amqp/implementation/handler/WebSocketsProxyConnectionHandler.java
Outdated
Show resolved
Hide resolved
...c/main/java/com/azure/core/amqp/implementation/handler/WebSocketsProxyConnectionHandler.java
Outdated
Show resolved
Hide resolved
...c/main/java/com/azure/core/amqp/implementation/handler/WebSocketsProxyConnectionHandler.java
Outdated
Show resolved
Hide resolved
chrischild
pushed a commit
to chrischild/azure-sdk-for-java
that referenced
this pull request
Oct 5, 2019
* Add WebSocketsProxyConnectionHandler. * Update ReactorHandlerProvider to connect proxy. * Add Objects.requiresNotNull check. * Integration web proxy handler in ReactorConnection. * Fix API for MockReactorHandlerProvider. * Adding tests for WebSocketsProxyConnectionHandler. * Use logger.throw * Adding tests for ReactorHandlerProvider. * Adding documentation to WebSocketsProxyConnectionHandler. Using SystemDefaults when a proxy should be used. * Asserting UserAgent string is in connection properties. * Adding simple proxy for integration tests. * Update IntegrationTestBase to getProxyConfiguration from configuration. * Add ProxyIntegrationTest. * Add ProxyReceiveTest. * Handling PROTON_IO errors. * Add integration tests for proxy configuration. * Cleaning up simple proxy. * Ignore tests until simple proxy is fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3580